Changeset 64428 in vbox for trunk/src/libs

Timestamp:

Oct 26, 2016 12:35:20 PM (8 years ago)

Author:

vboxsync

Message:

xpcom/Runtime: introduced NS_ERROR_SOCKET_FAIL which is used for XPCOM socket errors at /tmp/.vbox-*-ipc/ipcd

Location:

trunk/src/libs/xpcom18a4

Files:

• ipc/ipcd/client/src/ipcConnectionUnix.cpp (modified) (2 diffs)
• xpcom/base/nsError.h (modified) (1 diff)
• xpcom/components/nsComponentManager.cpp (modified) (1 diff)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcConnectionUnix.cpp

@@ -420 +420 @@
   PRNetAddr addr;
   PRSocketOptionData opt;
-  nsresult rv = NS_ERROR_FAILURE;
+  // don't use NS_ERROR_FAILURE as we want to detect these kind of errors
+  // in the frontend
+  nsresult rv = NS_ERROR_SOCKET_FAIL;
 
   fd = PR_OpenTCPSocket(PR_AF_LOCAL);
@@ -480 +482 @@
   if (NS_FAILED(rv))
   {
-    rv = IPC_SpawnDaemon(daemonPath);
+    nsresult rv1 = IPC_SpawnDaemon(daemonPath);
+    if (NS_SUCCEEDED(rv1) || rv != NS_ERROR_SOCKET_FAIL)
+      rv = rv1; 
     if (NS_SUCCEEDED(rv))
       rv = TryConnect(&fd);

trunk/src/libs/xpcom18a4/xpcom/base/nsError.h

@@ -215 +215 @@
 #define NS_ERROR_FACTORY_EXISTS            (NS_ERROR_BASE + 0x100)
 
+/* Socket failures */
+#define NS_ERROR_SOCKET_FAIL               (NS_ERROR_BASE + 0x200)
+
 
 /* For COM compatibility reasons, we want to use exact error code numbers

trunk/src/libs/xpcom18a4/xpcom/components/nsComponentManager.cpp

@@ -1962 +1962 @@
     {
         // Translate error values
-        rv = NS_ERROR_FACTORY_NOT_REGISTERED;
+        if (rv != NS_ERROR_SOCKET_FAIL)
+            rv = NS_ERROR_FACTORY_NOT_REGISTERED;
     }