Changeset 64432 in vbox for trunk

Timestamp:

Oct 26, 2016 4:57:32 PM (8 years ago)

Author:

vboxsync

Message:

HostDrivers/Darwin,VBoxGuest/Darwin: Some notes about why we don't require to call task_reference() in initWithTask()

Location:

trunk/src/VBox

Files:

• Additions/common/VBoxGuest/VBoxGuest-darwin.cpp (modified) (1 diff)
• HostDrivers/Support/darwin/SUPDrv-darwin.cpp (modified) (1 diff)
• HostDrivers/VBoxUSB/darwin/VBoxUSB.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-darwin.cpp

@@ -984 +984 @@
     if (IOUserClient::initWithTask(OwningTask, pvSecurityId , u32Type))
     {
+        /*
+         * In theory we have to call task_reference() to make sure that the task is
+         * valid during the lifetime of this object. The pointer is only used to check
+         * for the context this object is called in though and never dereferenced
+         * or passed to anything which might, so we just skip this step.
+         */
         m_Task = OwningTask;
         m_pSession = NULL;

trunk/src/VBox/HostDrivers/Support/darwin/SUPDrv-darwin.cpp

@@ -1660 +1660 @@
     if (IOUserClient::initWithTask(OwningTask, pvSecurityId , u32Type))
     {
+        /*
+         * In theory we have to call task_reference() to make sure that the task is
+         * valid during the lifetime of this object. The pointer is only used to check
+         * for the context this object is called in though and never dereferenced
+         * or passed to anything which might, so we just skip this step.
+         */
         m_Task = OwningTask;
         m_pSession = NULL;

trunk/src/VBox/HostDrivers/VBoxUSB/darwin/VBoxUSB.cpp

@@ -599 +599 @@
     if (IOUserClient::initWithTask(OwningTask, pvSecurityId , u32Type))
     {
+        /*
+         * In theory we have to call task_reference() to make sure that the task is
+         * valid during the lifetime of this object. The pointer is only used to check
+         * for the context this object is called in though and never dereferenced
+         * or passed to anything which might, so we just skip this step.
+         */
         m_pProvider = NULL;
         m_Task = OwningTask;