Changeset 64766 in vbox for trunk/src/VBox/Storage/QED.cpp

Timestamp:

Nov 30, 2016 10:59:48 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112111

Message:

src/VBox: Make the use of the iterator for RTListForEach()/RTListForEachSafe() more obvious. There is no need to initialize the iterator and we also must not depend on the iterator being NULL if the list was empty.

File:

• trunk/src/VBox/Storage/QED.cpp (modified) (5 diffs)

trunk/src/VBox/Storage/QED.cpp

@@ -393 +393 @@
 static void qedL2TblCacheDestroy(PQEDIMAGE pImage)
 {
-    PQEDL2CACHEENTRY pL2Entry = NULL;
-    PQEDL2CACHEENTRY pL2Next  = NULL;
-
+    PQEDL2CACHEENTRY pL2Entry;
+    PQEDL2CACHEENTRY pL2Next;
     RTListForEachSafe(&pImage->ListSearch, pL2Entry, pL2Next, QEDL2CACHEENTRY, NodeSearch)
     {
@@ -419 +418 @@
 static PQEDL2CACHEENTRY qedL2TblCacheRetain(PQEDIMAGE pImage, uint64_t offL2Tbl)
 {
-    PQEDL2CACHEENTRY pL2Entry = NULL;
-
+    PQEDL2CACHEENTRY pL2Entry;
     RTListForEach(&pImage->ListSearch, pL2Entry, QEDL2CACHEENTRY, NodeSearch)
     {
@@ -530 +528 @@
 static void qedL2TblCacheEntryInsert(PQEDIMAGE pImage, PQEDL2CACHEENTRY pL2Entry)
 {
-    PQEDL2CACHEENTRY pIt = NULL;
-
     Assert(pL2Entry->offL2Tbl > 0);
 
@@ -544 +540 @@
     {
         /* Insert into search list. */
+        PQEDL2CACHEENTRY pIt;
         pIt = RTListGetFirst(&pImage->ListSearch, QEDL2CACHEENTRY, NodeSearch);
         if (pIt->offL2Tbl > pL2Entry->offL2Tbl)
@@ -561 +558 @@
                 }
             }
-             Assert(fInserted);
+            Assert(fInserted);
         }
     }