Changeset 64849 in vbox for trunk

Timestamp:

Dec 13, 2016 2:41:04 PM (8 years ago)

Author:

vboxsync

Message:

Audio/DevHDA.cpp: Make sure to lower interrupt line if INTCTL / GIE is cleared.

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -208 +208 @@
 #define HDA_INTCTL_S7_SHIFT         7
 #define INTCTL_SX(pThis, X)         (HDA_REG_FLAG_VALUE((pThis), INTCTL, S##X))
+#define HDA_INTCTL_GIE_MASK         RT_BIT(31) /* Global Interrupt Enable (3.3.14). */
 
 #define HDA_REG_INTSTS              12 /* 0x24 */
@@ -2176 +2177 @@
     RT_NOREF(iReg);
 
+    int rc;
+
     HDA_REG(pThis, INTCTL) = u32Value;
 
-    return hdaProcessInterrupt(pThis);
+    /* Global Interrupt Enable (GIE) set? */
+    if (u32Value & HDA_INTCTL_GIE_MASK)
+    {
+        rc = hdaProcessInterrupt(pThis);
+    }
+    else
+    {
+        /** @todo Clear INTSTS's individual stream status bits as well? */
+
+        /* Make sure to lower interrupt line, as Global Interrupt Enable (GIE) is disabled. */
+        PDMDevHlpPCISetIrq(pThis->CTX_SUFF(pDevIns), 0, 0 /* iLevel */);
+
+        rc = VINF_SUCCESS;
+    }
+
+    return rc;
 }