Changeset 64851 in vbox

Timestamp:

Dec 13, 2016 4:46:27 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112251

Message:

VMM/PDM: Fix uninitialized variable in PDMGetInterrupt() when APIC TPR masks interrupt and caller expects a valid interrupt.

File:

• trunk/src/VBox/VMM/VMMAll/PDMAll.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/PDMAll.cpp

@@ -63 +63 @@
         VMCPU_FF_CLEAR(pVCpu, VMCPU_FF_INTERRUPT_APIC);
         uint32_t uTagSrc;
-        uint8_t  uVector;
-        rc = APICGetInterrupt(pVCpu, &uVector, &uTagSrc);
+        rc = APICGetInterrupt(pVCpu, pu8Interrupt, &uTagSrc);
         if (RT_SUCCESS(rc))
         {
-            *pu8Interrupt = uVector;
             if (rc == VINF_SUCCESS)
-                VBOXVMM_PDM_IRQ_GET(pVCpu, RT_LOWORD(uTagSrc), RT_HIWORD(uTagSrc), uVector);
+                VBOXVMM_PDM_IRQ_GET(pVCpu, RT_LOWORD(uTagSrc), RT_HIWORD(uTagSrc), *pu8Interrupt);
             return rc;
         }