Changeset 64909 in vbox

Timestamp:

Dec 16, 2016 1:34:56 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112319

Message:

DevPciIch9.cpp: fix MMIO BAR mapping bug which crept into r111601, plus removing a todo comment which isn't a todo (as bridges can have BARs, too)

File:

• trunk/src/VBox/Devices/Bus/DevPciIch9.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Bus/DevPciIch9.cpp

@@ -1968 +1968 @@
                     if (   uMemBase < uLast
                         && uMemBase > 0
-                        && !(   uNew  <= UINT32_C(0xffffffff)
-                             && uLast >= UINT32_C(0xfec00000)) )
+                        && !(   uMemBase <= UINT32_C(0xffffffff)
+                             && uLast    >= UINT32_C(0xfec00000)) )
                         uNew = uMemBase;
                 }
@@ -2169 +2169 @@
                         {
                             PCIDevSetByte(pPciDev, uAddress, bVal);
-                            fUpdateMappings = true; /** @todo r=bird: Probably not necessary to update mappings on VBOX_PCI_COMMAND changes for bridges? */
+                            fUpdateMappings = true;
                         }
                         break;