Changeset 64911 in vbox

Timestamp:

Dec 16, 2016 2:02:09 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112321

Message:

PGM: Fix sizing of last chunk for large MMIO (pre)registration.

File:

trunk/src/VBox/VMM/VMMR3/PGMPhys.cpp

-              r64399
+              r64911
         const size_t     cbRange = RT_OFFSETOF(PGMREGMMIORANGE, RamRange.aPages[cPagesTrackedByChunk]);
         PPGMREGMMIORANGE pNew    = NULL;
         if (   cPagesTrackedByChunk > cPagesLeft
+        if (   cPagesTrackedByChunk > cPagesLeft /**< @todo r=klaus the first part of the condition is guaranteed false due to RT_MIN above */
             || cbRange >= _1M)
+        {
 …
         *ppNext = pNew;
         ASMCompilerBarrier();
+        cPagesLeft -= cPagesTrackedByChunk;
         ppNext = &pNew->pNextR3;
+    }
+    Assert(cPagesLeft == 0);
     if (RT_SUCCESS(rc))
 …
+    }
     /*
+    /*
      * We're good, set the flags and invalid the mapping TLB.
      */

Note: See TracChangeset for help on using the changeset viewer.