Changeset 64987 in vbox for trunk/src/VBox/Frontends

Timestamp:

Dec 21, 2016 3:05:56 PM (8 years ago)

Author:

vboxsync

Message:

VBoxManage: proposal for a sanity check

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageDisk.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageDisk.cpp

@@ -504 +504 @@
     bool fModifyCompact = false;
     bool fModifyResize = false;
+    bool fModifyResizeMB = false;
     bool fModifyLocation = false;
     bool fModifyDescription = false;
@@ -591 +592 @@
                 cbResize = ValueUnion.u64 * _1M;
                 fModifyResize = true;
+                fModifyResizeMB = true; // do sanity check!
                 break;
 
@@ -670 +672 @@
         RTMsgError("Invalid medium reference, avoiding crash");
         return RTEXITCODE_FAILURE;
+    }
+
+    if (   fModifyResize
+        && fModifyResizeMB)
+    {
+        // Sanity check
+        //
+        // In general users should know what they do but in this case users have no
+        // alternative to VBoxManage. If happens that one wants to resize the disk
+        // and uses --resize and does not consider that this parameter expects the
+        // new medium size in MB not Byte. If the operation is started and then
+        // aborted by the user, the result is most likely a medium which doesn't
+        // work anymore.
+        LONG64 logicalSize;
+        pMedium->COMGETTER(LogicalSize)(&logicalSize);
+        if (cbResize > (uint64_t)logicalSize * _1M)
+        {
+            RTMsgError("Error: Attempt to resize the medium from %RU64.%RU64 MB to %RU64.%RU64 MB. Use --resizebyte is this is intended!\n",
+                    logicalSize / _1M, (logicalSize % _1M) / (_1M / 10), cbResize / _1M, (cbResize % _1M) / (_1M / 10));
+            return RTEXITCODE_FAILURE;
+        }
     }