Changeset 65033 in vbox

Timestamp:

Dec 29, 2016 11:10:03 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112528

Message:

testmanager/schedulerbase.py: More fixing on the problem of getting stuck doing nothing when a scheduling group is out of new builds to test.

File:

• trunk/src/VBox/ValidationKit/testmanager/core/schedulerbase.py (modified) (4 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/schedulerbase.py

@@ -1301 +1301 @@
               and oSchedGroup.idSchedGroup not in dIgnoreSchedGroupIds:
                 return (oSchedGroup, 0);
+            iWorkItem = 0;
 
         elif len(oTestBoxDataEx.aoInSchedGroups) > 0:
@@ -1340 +1341 @@
                 if aoFlat[iWorkItem].idSchedGroup not in dIgnoreSchedGroupIds:
                     return (aoFlat[iWorkItem], iWorkItem);
+        else:
+            iWorkItem = 0;
 
         # No active group.
-        return (None, 0);
+        return (None, iWorkItem);
 
     @staticmethod
@@ -1381 +1384 @@
 
                 # We may have to skip scheduling groups that are out of work (e.g. 'No build').
+                iInitialWorkItem     = iWorkItem;
                 dIgnoreSchedGroupIds = [];
                 while True:
@@ -1396 +1400 @@
                         oDb.commit();
                         return dResponse;
+
+                    # Check out the next work item?
+                    if oScheduler.getElapsedSecs() > config.g_kcSecMaxNewTask:
+                        break;
                     dIgnoreSchedGroupIds[oSchedGroup.idSchedGroup] = oSchedGroup;
+
+                # No luck, but best if we update the work item if we've made progress.
+                # Note! In case of a config.g_kcSecMaxNewTask timeout, this may accidentally skip
+                #       a work item with actually work to do.  But that's a small price to pay.
+                if iWorkItem != iInitialWorkItem:
+                    oTBStatusLogic.updateWorkItem(oTestBoxDataEx.idTestBox, iWorkItem);
+                    oDb.commit();
+                    return None;
         except:
             oDb.rollback();