Changeset 65060 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Jan 3, 2017 10:44:49 AM (8 years ago)

Author:

vboxsync

Message:

DevATA: Remove todo as it is already done now (in a different place in the passthrough path by saving the track lists/cue sheets)

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1809 +1809 @@
 static void atapiR3PassthroughCmdBT(ATADevState *s)
 {
-    /** @todo implement an algorithm for correctly determining the read and
-     * write sector size without sending additional commands to the drive.
-     * This should be doable by saving processing the configuration requests
-     * and replies. */
-# if 0
-    if (s->uTxDir == PDMMEDIATXDIR_TO_DEVICE)
-    {
-        uint8_t cmd = s->aATAPICmd[0];
-        if (cmd == SCSI_WRITE_10 || cmd == SCSI_WRITE_12 || cmd == SCSI_WRITE_AND_VERIFY_10)
-        {
-            uint8_t aModeSenseCmd[10];
-            uint8_t aModeSenseResult[16];
-            uint8_t uDummySense;
-            uint32_t cbTransfer;
-            int rc;
-
-            cbTransfer = sizeof(aModeSenseResult);
-            aModeSenseCmd[0] = SCSI_MODE_SENSE_10;
-            aModeSenseCmd[1] = 0x08; /* disable block descriptor = 1 */
-            aModeSenseCmd[2] = (SCSI_PAGECONTROL_CURRENT << 6) | SCSI_MODEPAGE_WRITE_PARAMETER;
-            aModeSenseCmd[3] = 0; /* subpage code */
-            aModeSenseCmd[4] = 0; /* reserved */
-            aModeSenseCmd[5] = 0; /* reserved */
-            aModeSenseCmd[6] = 0; /* reserved */
-            aModeSenseCmd[7] = cbTransfer >> 8;
-            aModeSenseCmd[8] = cbTransfer & 0xff;
-            aModeSenseCmd[9] = 0; /* control */
-            rc = s->pDrvMedia->pfnSendCmd(s->pDrvMedia, aModeSenseCmd, PDMMEDIATXDIR_FROM_DEVICE, aModeSenseResult, &cbTransfer, &uDummySense, 500);
-            if (RT_FAILURE(rc))
-            {
-                atapiR3CmdErrorSimple(s, SCSI_SENSE_ILLEGAL_REQUEST, SCSI_ASC_NONE);
-                return;
-            }
-            /* Select sector size based on the current data block type. */
-            switch (aModeSenseResult[12] & 0x0f)
-            {
-                case 0:
-                    s->cbATAPISector = 2352;
-                    break;
-                case 1:
-                    s->cbATAPISector = 2368;
-                    break;
-                case 2:
-                case 3:
-                    s->cbATAPISector = 2448;
-                    break;
-                case 8:
-                case 10:
-                    s->cbATAPISector = 2048;
-                    break;
-                case 9:
-                    s->cbATAPISector = 2336;
-                    break;
-                case 11:
-                    s->cbATAPISector = 2056;
-                    break;
-                case 12:
-                    s->cbATAPISector = 2324;
-                    break;
-                case 13:
-                    s->cbATAPISector = 2332;
-                    break;
-                default:
-                    s->cbATAPISector = 0;
-            }
-            Log2(("%s: sector size %d\n", __FUNCTION__, s->cbATAPISector));
-            s->cbTotalTransfer *= s->cbATAPISector;
-            if (s->cbTotalTransfer == 0)
-                s->uTxDir = PDMMEDIATXDIR_NONE;
-        }
-    }
-# endif
     atapiR3CmdBT(s);
 }