Changeset 65196 in vbox for trunk/src/VBox/ValidationKit/common

Timestamp:

Jan 9, 2017 11:07:28 AM (8 years ago)

Author:

vboxsync

Message:

common/utils.py,testboxscript,tdUnitTest1: Create separate windows (console) process groups for children so we can safely generate Ctrl-C signals without also committing suicide. (testdriver.base.spawn already did this)

File:

• trunk/src/VBox/ValidationKit/common/utils.py (modified) (4 diffs)

trunk/src/VBox/ValidationKit/common/utils.py

@@ -435 +435 @@
     return None;
 
+def processPopenSafe(*aPositionalArgs, **dKeywordArgs):
+    """
+    Wrapper for subprocess.Popen that's Ctrl-C safe on windows.
+    """
+    if getHostOs() == 'win':
+        if dKeywordArgs.get('creationflags', 0) == 0:
+            dKeywordArgs['creationflags'] = subprocess.CREATE_NEW_PROCESS_GROUP;
+    return subprocess.Popen(*aPositionalArgs, **dKeywordArgs);
+
 def processCall(*aPositionalArgs, **dKeywordArgs):
     """
-    Wrapper around subprocess.call to deal with its absense in older
+    Wrapper around subprocess.call to deal with its absence in older
     python versions.
     Returns process exit code (see subprocess.poll).
@@ -444 +453 @@
     assert dKeywordArgs.get('stderr') is None;
     _processFixPythonInterpreter(aPositionalArgs, dKeywordArgs);
-    oProcess = subprocess.Popen(*aPositionalArgs, **dKeywordArgs);
+    oProcess = processPopenSafe(*aPositionalArgs, **dKeywordArgs);
     return oProcess.wait();
 
@@ -453 +462 @@
     """
     _processFixPythonInterpreter(aPositionalArgs, dKeywordArgs);
-    oProcess = subprocess.Popen(stdout=subprocess.PIPE, *aPositionalArgs, **dKeywordArgs);
+    oProcess = processPopenSafe(stdout=subprocess.PIPE, *aPositionalArgs, **dKeywordArgs);
 
     sOutput, _ = oProcess.communicate();
@@ -541 +550 @@
 def sudoProcessPopen(*aPositionalArgs, **dKeywordArgs):
     """
-    sudo (or similar) + subprocess.Popen.
+    sudo (or similar) + processPopenSafe.
     """
     _processFixPythonInterpreter(aPositionalArgs, dKeywordArgs);
     _sudoFixArguments(aPositionalArgs, dKeywordArgs);
-    return subprocess.Popen(*aPositionalArgs, **dKeywordArgs);
+    return processPopenSafe(*aPositionalArgs, **dKeywordArgs);