Changeset 65207 in vbox for trunk/src/VBox/VMM

Timestamp:

Jan 9, 2017 1:54:22 PM (8 years ago)

Author:

vboxsync

Message:

iemCImpl_BranchCallGate: Added @todo on workaround from r112681, fixed style and added two testcase suggestions.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h

@@ -1380 +1380 @@
             {
                 /* Just grab the new (NULL) SS descriptor. */
+                /** @todo testcase: Check whether the zero GDT entry is actually loaded here
+                 *        like we do... */
                 rcStrict = iemMemFetchSelDesc(pVCpu, &DescSS, uNewSS, X86_XCPT_SS);
                 if (rcStrict != VINF_SUCCESS)
@@ -1417 +1419 @@
             GCPtrParmWds = pCtx->ss.u64Base + uOldRsp;
 
-            /* Probe if the write to the new stack will succeed. May #SS(NewSS) or #PF. */
-            void     *pvNewFrame;
+            /* HACK ALERT! Probe if the write to the new stack will succeed. May #SS(NewSS)
+                           or #PF, the former is not implemented in this workaround. */
+            /** @todo Proper fix callgate target stack exceptions. */
+            /** @todo testcase: Cover callgates with partially or fully inaccessible
+             *        target stacks. */
+            void    *pvNewFrame;
             RTGCPTR  GCPtrNewStack = X86DESC_BASE(&DescSS.Legacy) + uNewRsp - cbNewStack;
             rcStrict = iemMemMap(pVCpu, &pvNewFrame, cbNewStack, UINT8_MAX, GCPtrNewStack, IEM_ACCESS_SYS_RW);
@@ -1446 +1452 @@
 
             /* At this point the stack access must not fail because new state was already committed. */
+            /** @todo this can still fail due to SS.LIMIT not check.   */
             rcStrict = iemMemStackPushBeginSpecial(pVCpu, cbNewStack,
                                                    &uPtrRet.pv, &uNewRsp);
             AssertMsgReturn(rcStrict == VINF_SUCCESS, ("BranchCallGate: New stack mapping failed (%Rrc)\n", VBOXSTRICTRC_VAL(rcStrict)),
-                            VERR_IPE_UNEXPECTED_STATUS);
+                            VERR_INTERNAL_ERROR_5);
 
             if (!IEM_IS_LONG_MODE(pVCpu))
@@ -1459 +1466 @@
                     uPtrRet.pu32[1] = pCtx->cs.Sel; /** @todo Testcase: What is written to the high word when pushing CS? */
 
-                    if (cbWords) {
+                    if (cbWords)
+                    {
                         /* Map the relevant chunk of the old stack. */
                         rcStrict = iemMemMap(pVCpu, &uPtrParmWds.pv, cbWords * 4, UINT8_MAX, GCPtrParmWds, IEM_ACCESS_DATA_R);
@@ -1493 +1501 @@
                     uPtrRet.pu16[1] = pCtx->cs.Sel;
 
-                    if (cbWords) {
+                    if (cbWords)
+                    {
                         /* Map the relevant chunk of the old stack. */
                         rcStrict = iemMemMap(pVCpu, &uPtrParmWds.pv, cbWords * 2, UINT8_MAX, GCPtrParmWds, IEM_ACCESS_DATA_R);