Changeset 65279 in vbox

Timestamp:

Jan 13, 2017 11:45:20 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112837

Message:

SharedFolders: additional check

File:

• trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp (modified) (7 diffs)

trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp

@@ -147 +147 @@
  *
  * @returns iprt status code
+ * @param  fWritable  whether the shared folder is writable
  * @param  fShflFlags shared folder create flags
  * @param  fMode      file attributes
@@ -152 +153 @@
  * @retval pfOpen     iprt create flags
  */
-static int vbsfConvertFileOpenFlags(unsigned fShflFlags, RTFMODE fMode, SHFLHANDLE handleInitial, uint32_t *pfOpen)
+static int vbsfConvertFileOpenFlags(bool fWritable, unsigned fShflFlags, RTFMODE fMode, SHFLHANDLE handleInitial, uint32_t *pfOpen)
 {
     uint32_t fOpen = 0;
@@ -368 +369 @@
     if (RT_SUCCESS(rc))
     {
+        if (!fWritable)
+            fOpen &= ~RTFILE_O_WRITE;
+
         *pfOpen = fOpen;
     }
@@ -378 +382 @@
  * @returns IPRT status code
  * @param  pClient               Data structure describing the client accessing the shared folder
+ * @param  root                  The index of the shared folder in the table of mappings.
  * @param  pszPath               Path to the file or folder on the host.
  * @param  pParms @a CreateFlags Creation or open parameters, see include/VBox/shflsvc.h
@@ -388 +393 @@
  * @retval pParms @a Info        On success the parameters of the file opened or created
  */
-static int vbsfOpenFile(SHFLCLIENTDATA *pClient, const char *pszPath, SHFLCREATEPARMS *pParms)
+static int vbsfOpenFile(SHFLCLIENTDATA *pClient, SHFLROOT root, const char *pszPath, SHFLCREATEPARMS *pParms)
 {
     LogFlow(("vbsfOpenFile: pszPath = %s, pParms = %p\n", pszPath, pParms));
@@ -400 +405 @@
     static int cErrors;
 
-    int rc = vbsfConvertFileOpenFlags(pParms->CreateFlags, pParms->Info.Attr.fMode, pParms->Handle, &fOpen);
+    /* is the guest allowed to write to this share? */
+    bool fWritable;
+    int rc = vbsfMappingsQueryWritable(pClient, root, &fWritable);
+    if (RT_FAILURE(rc))
+        fWritable = false;
+
+    rc = vbsfConvertFileOpenFlags(fWritable, pParms->CreateFlags, pParms->Info.Attr.fMode, pParms->Handle, &fOpen);
     if (RT_SUCCESS(rc))
     {
@@ -878 +889 @@
                 else
                 {
-                    rc = vbsfOpenFile(pClient, pszFullPath, pParms);
+                    rc = vbsfOpenFile(pClient, root, pszFullPath, pParms);
                 }
             }