Changeset 65282 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jan 13, 2017 1:32:28 PM (8 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:6899: Accessibility support (step 171): A bit of care for UIInformationView: Here and there, mostly coding-style.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information

Files:

• UIInformationView.cpp (modified) (4 diffs)
• UIInformationView.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIInformationView.cpp

@@ -20 +20 @@
 #else  /* !VBOX_WITH_PRECOMPILED_HEADERS */
 
+/* Qt includes: */
+# include <QClipboard>
 # include <QTextEdit>
-# include <QClipboard>
 
 /* GUI includes: */
@@ -29 +30 @@
 #endif /* !VBOX_WITH_PRECOMPILED_HEADERS */
 
+
 UIInformationView::UIInformationView(QWidget *pParent)
     : QListView(pParent)
 {
-    /* Create a dummy textEdit for copying rich-text as,
-     * manual copying to clipboard is not working: */
+    // WORKAROUND:
+    // Create a dummy text-edit for copying rich-text
+    // as manual copying to clipboard is not working:
     m_pTextEdit = new QTextEdit(this);
-    /* Hide textedit: */
     m_pTextEdit->setVisible(false);
     /* Set selection mode: */
@@ -46 +48 @@
 {
     /* Iterate through all indexes: */
-    for (int iRowIndex = topLeft.row(); iRowIndex <= bottomRight.row(); iRowIndex++)
+    for (int iRowIndex = topLeft.row(); iRowIndex <= bottomRight.row(); ++iRowIndex)
     {
         /* Get the index for current row: */
-        QModelIndex index = topLeft.sibling(iRowIndex, topLeft.column());
+        const QModelIndex index = topLeft.sibling(iRowIndex, topLeft.column());
         /* If index is valid: */
         if (index.isValid())
         {
             /* Get the row-count of data-table: */
-            int iCount = index.data(Qt::UserRole + 1).value<UITextTable>().count();
+            const int iCount = index.data(Qt::UserRole + 1).value<UITextTable>().count();
             /* If there is no data hide the item: */
             if (iCount == 0)
@@ -68 +70 @@
     {
         QString strText;
-        /* Get Selection model: */
+        /* Get selection model: */
         QItemSelectionModel *pSelectionModel = selectionModel();
         if (pSelectionModel)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIInformationView.h

@@ -27 +27 @@
 class UIInformationItem;
 
+
 /** QListView extension
   * providing GUI with information-view in session-information window. */
@@ -34 +35 @@
 
 public:
-    /** Constructs information-view passing @a pParent to base-class. */
+
+    /** Constructs information-view passing @a pParent to the base-class. */
     UIInformationView(QWidget *pParent = 0);
 
 public slots:
+
     /** Handles updating data for the index-range @a topLeft to @a bottomRight. */
     void updateData(const QModelIndex &topLeft, const QModelIndex &bottomRight);
 
 protected slots:
+
     /** Handles Qt key-press @a pEvent. */
     void keyPressEvent(QKeyEvent *pEvent);
 
 private:
-    /** Holds the instance of textedit we create. */
+
+    /** Holds the text-edit instance. */
     QTextEdit *m_pTextEdit;
 };