Changeset 6547 in vbox for trunk/src/VBox/Additions/x11

Timestamp:

Jan 29, 2008 12:58:28 AM (17 years ago)

Author:

vboxsync

Message:

Another VbglR3SetPointerShape todo.

File:

• trunk/src/VBox/Additions/x11/xgraphics/vboxutils-new.c (modified) (2 diffs)

trunk/src/VBox/Additions/x11/xgraphics/vboxutils-new.c

@@ -652 +652 @@
     if ((bitsp->xhot > w) || (bitsp->yhot > h))
         RETERROR(scrnIndex, ,
-            "Error invalid cursor hotspot location %dx%d (max %dx%d)\n",
-            bitsp->xhot, bitsp->yhot, w, h);
+                 "Error invalid cursor hotspot location %dx%d (max %dx%d)\n",
+                 bitsp->xhot, bitsp->yhot, w, h);
 
     pVBox->pointerSize = w * h * 4 + sizeMask;
@@ -660 +660 @@
     if (!p)
         RETERROR(scrnIndex, ,
-            "Error failed to alloc %lu bytes for cursor\n",
-            (unsigned long) sizeRequest);
-
+                 "Error failed to alloc %lu bytes for cursor\n",
+                 (unsigned long)sizeRequest);
+
+    /** @todo r=bird: The VbglR3SetPointerShape API and this code seems to 
+     * end up doing the stuff twice, at least wrt memory. It would make much 
+     * more sense to have a VbglR3SetPointerShape version which took a 
+     * VMMDevReqMousePointer pointer instead. Sorry for not spotting this 
+     * the first time around. */
     reqp = (VMMDevReqMousePointer *)p;
     *reqp = *pVBox->reqp;