Changeset 65715 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Feb 9, 2017 5:02:28 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

113424

Message:

VMM/DBGFAddrSpace: no need to retain a debug address space we just created unless it is attached several times -- the initial cRef value is 1 not 0. Without this fix these address spaces are never freed on termination.

File:

• trunk/src/VBox/VMM/VMMR3/DBGFAddrSpace.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR3/DBGFAddrSpace.cpp

@@ -233 +233 @@
     rc = DBGFR3AsAdd(pUVM, hDbgAs, NIL_RTPROCESS);
     AssertRCReturn(rc, rc);
-    RTDbgAsRetain(hDbgAs);
     pUVM->dbgf.s.ahAsAliases[DBGF_AS_ALIAS_2_INDEX(DBGF_AS_GLOBAL)] = hDbgAs;
 
@@ -243 +242 @@
     rc = DBGFR3AsAdd(pUVM, hDbgAs, NIL_RTPROCESS);
     AssertRCReturn(rc, rc);
-    RTDbgAsRetain(hDbgAs);
     pUVM->dbgf.s.ahAsAliases[DBGF_AS_ALIAS_2_INDEX(DBGF_AS_PHYS)] = hDbgAs;
 
@@ -250 +248 @@
     rc = DBGFR3AsAdd(pUVM, hDbgAs, NIL_RTPROCESS);
     AssertRCReturn(rc, rc);
-    RTDbgAsRetain(hDbgAs);
     pUVM->dbgf.s.ahAsAliases[DBGF_AS_ALIAS_2_INDEX(DBGF_AS_RC)] = hDbgAs;
     RTDbgAsRetain(hDbgAs);
@@ -259 +256 @@
     rc = DBGFR3AsAdd(pUVM, hDbgAs, NIL_RTPROCESS);
     AssertRCReturn(rc, rc);
-    RTDbgAsRetain(hDbgAs);
     pUVM->dbgf.s.ahAsAliases[DBGF_AS_ALIAS_2_INDEX(DBGF_AS_R0)] = hDbgAs;
 
@@ -308 +304 @@
         pUVM->dbgf.s.ahAsAliases[i] = NIL_RTDBGAS;
     }
+
+    /*
+     * Release the reference to the debugging config.
+     */
+    rc = RTDbgCfgRelease(pUVM->dbgf.s.hDbgCfg);
+    AssertRC(rc);
 }