Changeset 65797 in vbox for trunk/src/VBox/Frontends

Timestamp:

Feb 16, 2017 9:34:40 AM (8 years ago)

Author:

vboxsync

Message:

FE/Qt: X11: Runtime UI: Mini-toolbar workaround for WMs which don't support transiency between full-screen frame-less windows.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/widgets

Files:

• UIMiniToolBar.cpp (modified) (1 diff)
• UIMiniToolBar.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIMiniToolBar.cpp

@@ -399 +399 @@
 *********************************************************************************************************************************/
 
+/* static */
+Qt::WindowFlags UIMiniToolBar::defaultWindowFlags(GeometryType geometryType)
+{
+    /* Not everywhere: */
+    Q_UNUSED(geometryType);
+
+#ifdef VBOX_WS_X11
+    /* Depending on current WM: */
+    switch (vboxGlobal().typeOfWindowManager())
+    {
+        // WORKAROUND:
+        // By strange reason, frameless full-screen windows under certain WMs
+        // do not respect the transient relationship between each other.
+        // By nor less strange reason, frameless full-screen *tool* windows
+        // respects such relationship, so we are doing what WM want.
+        case X11WMType_GNOMEShell:
+        case X11WMType_Metacity:
+        case X11WMType_Mutter:
+            printf("hack\n");
+            return geometryType == GeometryType_Full ?
+                   Qt::Tool | Qt::FramelessWindowHint :
+                   Qt::Window | Qt::FramelessWindowHint;
+        default: break;
+    }
+#endif /* VBOX_WS_X11 */
+
+    /* Frameless window by default: */
+    return Qt::Window | Qt::FramelessWindowHint;
+}
+
 UIMiniToolBar::UIMiniToolBar(QWidget *pParent,
                              GeometryType geometryType,
                              Qt::Alignment alignment,
                              bool fAutoHide /* = true */)
-    : QWidget(0, Qt::Window | Qt::FramelessWindowHint)
+    : QWidget(0, defaultWindowFlags(geometryType))
     /* Variables: General stuff: */
     , m_pParent(pParent)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIMiniToolBar.h

@@ -66 +66 @@
 
 public:
+
+    /** Proposes default set of window flags for particular platform. */
+    static Qt::WindowFlags defaultWindowFlags(GeometryType geometryType);
 
     /** Constructor, passes @a pParent to the QWidget constructor.