Changeset 65856 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

Feb 23, 2017 12:24:04 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

113626

Message:

testdriver/reporter.py: Redid locking to account for garbage collection causing trouble when it calls del methods with log statements. Since those statements can be very useful, the reporter now disables GC while it's owning the lock, but allow recursion in case GC runs before we disables it or immediately after reenabling it.

File:

• trunk/src/VBox/ValidationKit/testdriver/reporter.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testdriver/reporter.py

@@ -76 +76 @@
 
         # Disable GC to avoid __del__ w/ log statement randomly reenter the logger.
-        self.fRestoreGC  = gc.isenabled();
-        if self.fRestoreGC:
-            gc.disable();
+        if cRecursion == 1:
+            self.fRestoreGC = gc.isenabled();
+            if self.fRestoreGC:
+                gc.disable();
 
         return True;