Changeset 65962 in vbox for trunk/src/VBox/VMM

Timestamp:

Mar 7, 2017 10:13:17 AM (8 years ago)

Author:

vboxsync

Message:

IEMAllInstructionsPython.py: pylint 2.0.0 fixes

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py (modified) (18 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py

@@ -500 +500 @@
         Raises BadValue if invalid value.
         """
-        if len(sValue) == 0:
+        if not sValue:
             raise TestType.BadValue('empty value');
 
@@ -1149 +1149 @@
         Returns number of errors.
         """
-        if len(self.asErrors) > 0:
+        if self.asErrors:
             sys.stderr.write(u''.join(self.asErrors));
         return len(self.asErrors);
@@ -1177 +1177 @@
             asWords = sStats.split('_');
             oInstr.sMnemonic = asWords[0].lower();
-            if len(asWords) > 1 and len(oInstr.aoOperands) == 0:
+            if len(asWords) > 1 and not oInstr.aoOperands:
                 for sType in asWords[1:]:
                     if sType in g_kdOpTypes:
@@ -1248 +1248 @@
         # Derive encoding from operands.
         if oInstr.sEncoding is None:
-            if len(oInstr.aoOperands) == 0:
+            if not oInstr.aoOperands:
                 oInstr.sEncoding = 'fixed';
             elif oInstr.aoOperands[0].usesModRM():
@@ -1259 +1259 @@
         # Apply default map and then add the instruction to all it's groups.
         #
-        if len(oInstr.aoMaps) == 0:
+        if not oInstr.aoMaps:
             oInstr.aoMaps = [ self.oDefaultMap, ];
         for oMap in oInstr.aoMaps:
@@ -1324 +1324 @@
     def ensureInstructionForOpTag(self, iTagLine):
         """ Ensure there is an instruction for the op-tag being parsed. """
-        if len(self.aoCurInstrs) == 0:
+        if not self.aoCurInstrs:
             self.addInstruction(self.iCommentLine + iTagLine);
         for oInstr in self.aoCurInstrs:
@@ -1340 +1340 @@
         asRet = [];
         for asLines in aasSections:
-            if len(asLines) > 0:
+            if asLines:
                 asRet.append(' '.join([sLine.strip() for sLine in asLines]));
         return asRet;
@@ -1356 +1356 @@
         sRet = '';
         for iSection, asLines in enumerate(aasSections):
-            if len(asLines) > 0:
+            if asLines:
                 if iSection > 0:
                     sRet += sSectionSep;
@@ -1378 +1378 @@
         # Flatten and validate the value.
         sBrief = self.flattenAllSections(aasSections);
-        if len(sBrief) == 0:
+        if not sBrief:
             return self.errorComment(iTagLine, '%s: value required' % (sTag,));
         if sBrief[-1] != '.':
@@ -1405 +1405 @@
         """
         oInstr = self.ensureInstructionForOpTag(iTagLine);
-        if len(aasSections) > 0:
+        if aasSections:
             oInstr.asDescSections.extend(self.flattenSections(aasSections));
             return True;
@@ -1498 +1498 @@
         sFlattened = self.flattenAllSections(aasSections, sLineSep = ',', sSectionSep = ',');
         asMaps = sFlattened.split(',');
-        if len(asMaps) == 0:
+        if not asMaps:
             return self.errorComment(iTagLine, '%s: value required' % (sTag,));
         for sMap in asMaps:
@@ -1742 +1742 @@
         if len(asWords) != 1:
             self.errorComment(iTagLine, '%s: expected exactly one value: %s' % (sTag, asWords,));
-            if len(asWords) == 0:
+            if not asWords:
                 return False;
         sDisEnum = asWords[0];
@@ -1911 +1911 @@
             #
             sFlatSection = self.flattenAllSections([asSectionLines,]);
-            if len(sFlatSection) == 0:
+            if not sFlatSection:
                 self.errorComment(iTagLine, '%s: missing value' % ( sTag,));
                 continue;
@@ -2118 +2118 @@
             asLines[iLine] = sLine.lstrip().lstrip('*').lstrip();
 
-        while len(asLines) > 0 and len(asLines[0]) == 0:
+        while asLines and not asLines[0]:
             self.iCommentLine += 1;
             asLines.pop(0);
 
-        while len(asLines) > 0 and len(asLines[-1]) == 0:
+        while asLines and not asLines[-1]:
             asLines.pop(len(asLines) - 1);
 
@@ -2142 +2142 @@
         for iLine, sLine in enumerate(asLines):
             if not sLine.startswith('@'):
-                if len(sLine) > 0:
+                if sLine:
                     asCurSection.append(sLine);
-                elif len(asCurSection) != 0:
+                elif asCurSection:
                     asCurSection = [];
                     aasSections.append(asCurSection);
@@ -2189 +2189 @@
         # Don't allow default text in blocks containing @op*.
         #
-        if cOpTags > 0 and len(sFlatDefault) > 0:
+        if cOpTags > 0 and sFlatDefault:
             self.errorComment(0, 'Untagged comment text is not allowed with @op*: %s' % (sFlatDefault,));
 
@@ -2287 +2287 @@
 
         # Apply to the last instruction only for now.
-        if len(self.aoCurInstrs) == 0:
+        if not self.aoCurInstrs:
             self.addInstruction();
         oInstr = self.aoCurInstrs[-1];
@@ -2404 +2404 @@
                 sFunction = asArgs[1];
 
-                if len(self.aoCurInstrs) == 0:
+                if not self.aoCurInstrs:
                     self.addInstruction();
                 for oInstr in self.aoCurInstrs: