Changeset 66099 in vbox

Timestamp:

Mar 14, 2017 7:06:16 PM (8 years ago)

Author:

vboxsync

Message:

SharedFolders: Some adjustments necessary for flexible array syntax in SHFLSTRING.

Location:

trunk/src/VBox/HostServices/SharedFolders

Files:

• testcase/tstSharedFolderService.cpp (modified) (4 diffs)
• vbsf.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/SharedFolders/testcase/tstSharedFolderService.cpp

@@ -755 +755 @@
 
 static int listDir(VBOXHGCMSVCFNTABLE *psvcTable, SHFLROOT root,
-                   SHFLHANDLE handle, uint32_t fFlags, uint32_t cb,
+                   SHFLHANDLE handle, uint32_t fFlags,
                    const char *pcszPath, void *pvBuf, uint32_t cbBuf,
                    uint32_t resumePoint, uint32_t *pcFiles)
@@ -766 +766 @@
     aParms[1].setUInt64(handle);
     aParms[2].setUInt32(fFlags);
-    aParms[3].setUInt32(cb);
+    aParms[3].setUInt32(cbBuf);
     if (pcszPath)
     {
@@ -1020 +1020 @@
     PRTDIR pDir = (PRTDIR)&g_aTestDirHandles[g_iNextDirHandle++ % RT_ELEMENTS(g_aTestDirHandles)];
     SHFLHANDLE Handle;
-    SHFLDIRINFO DirInfo;
+    union
+    {
+        SHFLDIRINFO DirInfo;
+        uint8_t     abBuffer[sizeof(SHFLDIRINFO) + 2 * sizeof(RTUTF16)];
+    } Buf;
     uint32_t cFiles;
     int rc;
@@ -1031 +1035 @@
                     SHFL_CF_DIRECTORY | SHFL_CF_ACCESS_READ, &Handle, NULL);
     RTTEST_CHECK_RC_OK(hTest, rc);
-    rc = listDir(&svcTable, Root, Handle, 0, sizeof (SHFLDIRINFO), NULL,
-                 &DirInfo, sizeof(DirInfo), 0, &cFiles);
+    rc = listDir(&svcTable, Root, Handle, 0, NULL, &Buf.DirInfo, sizeof(Buf), 0, &cFiles);
     RTTEST_CHECK_RC(hTest, rc, VERR_NO_MORE_FILES);
     RTTEST_CHECK_MSG(hTest, g_testRTDirReadExDir == pDir, (hTest, "Dir=%p\n", g_testRTDirReadExDir));

trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp

@@ -1615 +1615 @@
     SHFLVOLINFO   *pSFDEntry;
     char          *pszFullPath = NULL;
-    SHFLSTRING     dummy;
+    union
+    {
+        SHFLSTRING  Dummy;
+        uint8_t     abDummy[SHFLSTRING_HEADER_SIZE + sizeof(RTUTF16)];
+    } Buf;
 
     if (pcbBuffer == 0 || pBuffer == 0 || *pcbBuffer < sizeof(SHFLVOLINFO))
@@ -1629 +1633 @@
     pSFDEntry   = (PSHFLVOLINFO)pBuffer;
 
-    ShflStringInitBuffer(&dummy, sizeof(dummy));
-    dummy.String.ucs2[0] = '\0';
-    rc = vbsfBuildFullPath(pClient, root, &dummy, sizeof(dummy), &pszFullPath, NULL);
+    ShflStringInitBuffer(&Buf.Dummy, sizeof(Buf));
+    Buf.Dummy.String.ucs2[0] = '\0';
+    rc = vbsfBuildFullPath(pClient, root, &Buf.Dummy, sizeof(Buf), &pszFullPath, NULL);
 
     if (RT_SUCCESS(rc))