Changeset 66117 in vbox for trunk/src/VBox/ValidationKit/bootsectors/bs3kit

Timestamp:

Mar 15, 2017 6:24:06 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

114007

Message:

bs3kit: Made Bs3TestFailed* return false as that's more convenient when using boolean success indicator in the test driver code.

Location:

trunk/src/VBox/ValidationKit/bootsectors/bs3kit

Files:

• bs3-cmn-TestFailed.c (modified) (5 diffs)
• bs3kit.h (modified) (1 diff)

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3-cmn-TestFailed.c

@@ -96 +96 @@
  */
 #undef Bs3TestFailedV
-BS3_CMN_DEF(void, Bs3TestFailedV,(const char *pszFormat, va_list va))
+BS3_CMN_DEF(bool, Bs3TestFailedV,(const char *pszFormat, va_list va))
 {
     BS3TESTFAILEDBUF Buf;
@@ -113 +113 @@
     Buf.cchBuf   = 0;
     Bs3StrFormatV(pszFormat, va, bs3TestFailedStrOutput, &Buf);
+    return false;
 }
 
@@ -120 +121 @@
  */
 #undef Bs3TestFailedF
-BS3_CMN_DEF(void, Bs3TestFailedF,(const char *pszFormat, ...))
+BS3_CMN_DEF(bool, Bs3TestFailedF,(const char *pszFormat, ...))
 {
     va_list va;
@@ -126 +127 @@
     BS3_CMN_NM(Bs3TestFailedV)(pszFormat, va);
     va_end(va);
+    return false;
 }
 
@@ -133 +135 @@
  */
 #undef Bs3TestFailed
-BS3_CMN_DEF(void, Bs3TestFailed,(const char *pszMessage))
+BS3_CMN_DEF(bool, Bs3TestFailed,(const char *pszMessage))
 {
-    BS3_CMN_NM(Bs3TestFailedF)("%s", pszMessage);
+    return BS3_CMN_NM(Bs3TestFailedF)("%s", pszMessage);
 }
 

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3kit.h

@@ -2987 +2987 @@
 /**
  * Equivalent to RTTestIFailed.
- */
-BS3_CMN_PROTO_STUB(void, Bs3TestFailed,(const char BS3_FAR *pszMessage));
+ * @returns false.
+ */
+BS3_CMN_PROTO_STUB(bool, Bs3TestFailed,(const char BS3_FAR *pszMessage));
 
 /**
  * Equivalent to RTTestIFailedF.
- */
-BS3_CMN_PROTO_STUB(void, Bs3TestFailedF,(const char BS3_FAR *pszFormat, ...));
+ * @returns false.
+ */
+BS3_CMN_PROTO_STUB(bool, Bs3TestFailedF,(const char BS3_FAR *pszFormat, ...));
 
 /**
  * Equivalent to RTTestIFailedV.
- */
-BS3_CMN_PROTO_STUB(void, Bs3TestFailedV,(const char BS3_FAR *pszFormat, va_list va));
+ * @returns false.
+ */
+BS3_CMN_PROTO_STUB(bool, Bs3TestFailedV,(const char BS3_FAR *pszFormat, va_list va));
 
 /**