Changeset 66319 in vbox

Timestamp:

Mar 29, 2017 6:33:37 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

114248

Message:

VMM: Nested Hw.virt: Todos.

File:

• trunk/src/VBox/VMM/VMMAll/HMSVMAll.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/HMSVMAll.cpp

@@ -652 +652 @@
             pCtx->rsp        = pHostState->uRsp;
             pCtx->rax        = pHostState->uRax;
-            /* The spec says "Disables all hardware breakpoints in DR7"... */
             pCtx->dr[7]     &= ~(X86_DR7_ENABLED_MASK | X86_DR7_RAZ_MASK | X86_DR7_MBZ_MASK);
             pCtx->dr[7]     |= X86_DR7_RA1_MASK;
+
+            /** @todo if RIP is not canonical or outside the CS segment limit, we need to
+             *        raise #GP(0) in the guest. */
+
+            /** @todo check the loaded host-state for consistency. Figure out what
+             *        exactly this involves? */
 
             rc = VINF_SVM_VMEXIT;