Changeset 66393 in vbox

Timestamp:

Apr 3, 2017 6:09:51 AM (8 years ago)

Author:

vboxsync

Message:

bugref:8019: Undefined behaviour sanitiser: do not introduce an unnecessary macro definition to tell if we are building with sanitisers, as SANITIZER_ADDRESS already exists.

Location:

trunk/src/VBox/HostServices/SharedOpenGL

Files:

• Makefile.kmk (modified) (1 diff)
• OpenGLTest/OpenGLTest.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/Makefile.kmk

@@ -408 +408 @@
 ifneq ($(KBUILD_TARGET),darwin)
   VBoxOGLTest_SOURCES = OpenGLTest/OpenGLTest.cpp
- ifneq ($(KBUILD_TARGET),win)
-  VBoxOGLTest_DEFS += $(if $(VBOX_WITH_GCC_SANITIZER),VBOX_WITH_GCC_SANITIZER,)
- endif
 endif
 VBoxOGLTest_SOURCES.darwin = OpenGLTest/OpenGLTestDarwin.cpp

trunk/src/VBox/HostServices/SharedOpenGL/OpenGLTest/OpenGLTest.cpp

@@ -45 +45 @@
     uint64_t StartTS;
 
-#ifdef VBOX_WITH_GCC_SANITIZER
+#ifdef __SANITIZE_ADDRESS__
     /* The OpenGL test tool contains a number of memory leaks which cause it to
      * return failure when run with ASAN unless we disable the leak detector. */
@@ -62 +62 @@
     AssertRCReturn(rc, false);
 
-#ifndef VBOX_WITH_GCC_SANITIZER
+#ifndef __SANITIZE_ADDRESS__
     rc = RTProcCreate(pszVBoxPath, papszArgs, RTENV_DEFAULT, 0, &Process);
 #else