Changeset 66660 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Apr 24, 2017 5:37:48 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

115033

Message:

FE/Qt: bugref:6911: UISession: Caching VM pixmap.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime

Files:

• UIMachineLogic.cpp (modified) (1 diff)
• UIMachineWindow.cpp (modified) (2 diffs)
• UISession.cpp (modified) (3 diffs)
• UISession.h (modified) (2 diffs)
• UIVMCloseDialog.cpp (modified) (3 diffs)
• UIVMCloseDialog.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineLogic.cpp

@@ -1554 +1554 @@
 
     /* Assign corresponding icon: */
-    const QPixmap pixmap = vboxGlobal().vmGuestOSTypePixmapDefault(guest().GetOSTypeId());
-    pDlg->mLbIcon->setPixmap(pixmap);
+    if (uisession() && uisession()->machineWindowIcon())
+        pDlg->mLbIcon->setPixmap(uisession()->machineWindowIcon()->pixmap(QSize(32, 32)));
 
     /* Search for the max available filter index: */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineWindow.cpp

@@ -182 +182 @@
 {
 #ifndef VBOX_WS_MAC
-    /* On Mac OS X window icon referenced in info.plist is used. */
-
-    /* Set default window icon (will be changed to VM-specific icon little bit later): */
-    setWindowIcon(QIcon(":/VirtualBox_48px.png"));
-
-    /* Set redefined machine-window icon if any: */
-    QIcon *pMachineWidnowIcon = uisession()->machineWindowIcon();
-    if (pMachineWidnowIcon)
-        setWindowIcon(*pMachineWidnowIcon);
-    /* Or set default machine-window icon: */
-    else
-        setWindowIcon(vboxGlobal().vmGuestOSTypeIcon(machine().GetOSTypeId()));
+    /* Set machine-window icon if any: */
+    // On macOS window icon is referenced in info.plist.
+    if (uisession() && uisession()->machineWindowIcon())
+        setWindowIcon(*uisession()->machineWindowIcon());
 #endif /* !VBOX_WS_MAC */
 }
@@ -346 +338 @@
                                                                   console().GetGuestEnteredACPIMode(),
                                                                   restrictedCloseActions);
+        /* Configure close-dialog: */
+        if (uisession() && uisession()->machineWindowIcon())
+            pCloseDlg->setPixmap(uisession()->machineWindowIcon()->pixmap(QSize(32, 32)));
 
         /* Make sure close-dialog is valid: */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

@@ -957 +957 @@
     , m_machineStatePrevious(KMachineState_Null)
     , m_machineState(KMachineState_Null)
-#ifndef VBOX_WS_MAC
     , m_pMachineWindowIcon(0)
-#endif /* !VBOX_WS_MAC */
     , m_requestedVisualStateType(UIVisualStateType_Invalid)
 #ifdef VBOX_WS_WIN
@@ -1289 +1287 @@
         const QString strMachineID = vboxGlobal().managedVMUuid();
 
+        /* Prepare machine-window icon: */
+        {
+            QIcon icon;
 #ifndef VBOX_WS_MAC
-        /* Load/prepare user's machine-window icon: */
-        QIcon icon;
-        foreach (const QString &strIconName, gEDataManager->machineWindowIconNames(strMachineID))
-            if (!strIconName.isEmpty() && QFile::exists(strIconName))
-                icon.addFile(strIconName);
-        if (!icon.isNull())
+            /* Load user machine-window icon: */
+            foreach (const QString &strIconName, gEDataManager->machineWindowIconNames(strMachineID))
+                if (!strIconName.isEmpty() && QFile::exists(strIconName))
+                    icon.addFile(strIconName);
+#endif
+            /* Use the OS type icon if user one was not set: */
+            if (icon.isNull())
+                icon = vboxGlobal().vmGuestOSTypeIcon(machine().GetOSTypeId());
+            /* Use the default icon if nothing else works: */
+            if (icon.isNull())
+                icon = QIcon(":/VirtualBox_48px.png");
+            /* Store the icon dynamically: */
             m_pMachineWindowIcon = new QIcon(icon);
-
+        }
+
+#ifndef VBOX_WS_MAC
         /* Load user's machine-window name postfix: */
         m_strMachineWindowNamePostfix = gEDataManager->machineWindowNamePostfix(strMachineID);
-#endif /* !VBOX_WS_MAC */
+#endif
 
         /* Is there should be First RUN Wizard? */
@@ -1368 +1377 @@
         }
 
-#ifndef VBOX_WS_MAC
-        /* Cleanup user's machine-window icon: */
+        /* Cleanup machine-window icon: */
         delete m_pMachineWindowIcon;
         m_pMachineWindowIcon = 0;
-#endif /* !VBOX_WS_MAC */
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.h

@@ -128 +128 @@
     QCursor cursor() const { return m_cursor; }
 
-#ifndef VBOX_WS_MAC
     /** @name Branding stuff.
      ** @{ */
-    /** Returns redefined machine-window icon. */
-    QIcon* machineWindowIcon() const { return m_pMachineWindowIcon; }
+    /** Returns the cached machine-window icon. */
+    QIcon *machineWindowIcon() const { return m_pMachineWindowIcon; }
+#ifndef VBOX_WS_MAC
     /** Returns redefined machine-window name postfix. */
     QString machineWindowNamePostfix() const { return m_strMachineWindowNamePostfix; }
-    /** @} */
-#endif /* !VBOX_WS_MAC */
+#endif
+    /** @} */
 
     /** @name Host-screen configuration variables.
@@ -459 +459 @@
     QCursor m_cursor;
 
-#ifndef VBOX_WS_MAC
     /** @name Branding variables.
      ** @{ */
-    /** Holds redefined machine-window icon. */
+    /** Holds the cached machine-window icon. */
     QIcon *m_pMachineWindowIcon;
+#ifndef VBOX_WS_MAC
     /** Holds redefined machine-window name postfix. */
     QString m_strMachineWindowNamePostfix;
-    /** @} */
-#endif /* !VBOX_WS_MAC */
+#endif
+    /** @} */
 
     /** @name Visual-state configuration variables.

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIVMCloseDialog.cpp

@@ -70 +70 @@
 }
 
+void UIVMCloseDialog::setPixmap(const QPixmap &pixmap)
+{
+    /* Make sure pixmap is valid: */
+    if (pixmap.isNull())
+        return;
+
+    /* Assign new pixmap: */
+    m_pIcon->setPixmap(pixmap);
+}
+
 void UIVMCloseDialog::sltUpdateWidgetAvailability()
 {
@@ -103 +113 @@
     /* Hide the dialog: */
     hide();
-}
-
-void UIVMCloseDialog::setPixmap(const QPixmap &pixmap)
-{
-    /* Make sure pixmap is valid: */
-    if (pixmap.isNull())
-        return;
-
-    /* Assign new pixmap: */
-    m_pIcon->setPixmap(pixmap);
 }
 
@@ -317 +317 @@
     KMachineState machineState = m_machine.GetState();
 
-    /* Assign pixmap: */
-    setPixmap(vboxGlobal().vmGuestOSTypePixmapDefault(m_machine.GetOSTypeId()));
-
     /* Check which close-actions are resticted: */
     bool fIsDetachAllowed = vboxGlobal().isSeparateProcess() && !(m_restictedCloseActions & MachineCloseAction_Detach);

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIVMCloseDialog.h

@@ -44 +44 @@
     bool isValid() const { return m_fValid; }
 
+    /* API: Pixmap stuff: */
+    void setPixmap(const QPixmap &pixmap);
+
 private slots:
 
@@ -53 +56 @@
 
 private:
-
-    /* API: Pixmap stuff: */
-    void setPixmap(const QPixmap &pixmap);
 
     /* API: Detach-button stuff: */