Changeset 66814 in vbox

Timestamp:

May 5, 2017 7:27:04 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

115235

Message:

IEM: clearly mark operands that are written to.

Location:

trunk

Files:

• include/VBox/disopcode.h (modified) (1 diff)
• src/VBox/VMM/VMMAll/IEMAllInstructionsOneByte.cpp.h (modified) (2 diffs)
• src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py (modified) (1 diff)
• src/VBox/ValidationKit/bootsectors/bs3-cpu-generated-1-template.c (modified) (4 diffs)
• src/VBox/ValidationKit/bootsectors/bs3-cpu-generated-1.h (modified) (2 diffs)

trunk/include/VBox/disopcode.h

@@ -1064 +1064 @@
 
 /* For making IEM / bs3-cpu-generated-1 happy: */
+#define OP_PARM_Gv_RO           OP_PARM_Gv              /**< Annotates read only first operand (default is readwrite). */
 #define OP_PARM_M_RO            OP_PARM_M               /**< Annotates read only memory of variable operand size (xrstor). */
 #define OP_PARM_M_RW            OP_PARM_M               /**< Annotates read-write memory of variable operand size (xsave). */

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsOneByte.cpp.h

@@ -1849 +1849 @@
  * @opcode      0x62
  * @opmnemonic  bound
- * @op1         Gv
+ * @op1         Gv_RO
  * @op2         Ma
  * @opmincpu    80186
@@ -1911 +1911 @@
     if (pVCpu->iem.s.enmCpuMode != IEMMODE_64BIT)
     {
-        IEMOP_MNEMONIC2(RM_MEM, BOUND, bound, Gv, Ma, DISOPTYPE_HARMLESS, IEMOPHINT_IGNORES_OP_SIZE);
+        IEMOP_MNEMONIC2(RM_MEM, BOUND, bound, Gv_RO, Ma, DISOPTYPE_HARMLESS, IEMOPHINT_IGNORES_OP_SIZE);
         IEMOP_HLP_MIN_186();
         IEM_OPCODE_GET_NEXT_U8(&bRm);

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py

@@ -248 +248 @@
     'Gw':           ( 'IDX_UseModRM',       'reg',    '%Gw',  'Gw',      ),
     'Gv':           ( 'IDX_UseModRM',       'reg',    '%Gv',  'Gv',      ),
+    'Gv_RO':        ( 'IDX_UseModRM',       'reg',    '%Gv',  'Gv',      ),
     'Pq_WO':        ( 'IDX_UseModRM',       'reg',    '%Pq',  'Pq',      ),
     'Vss':          ( 'IDX_UseModRM',       'reg',    '%Vss', 'Vss',     ),

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-generated-1-template.c

@@ -1848 +1848 @@
 
 
-static unsigned BS3_NEAR_CODE Bs3Cg1EncodeNext_BS3CG1ENC_MODRM_Gv_Ma(PBS3CG1STATE pThis, unsigned iEncoding)
+static unsigned BS3_NEAR_CODE Bs3Cg1EncodeNext_BS3CG1ENC_MODRM_Gv_RO_Ma(PBS3CG1STATE pThis, unsigned iEncoding)
 {
     unsigned off;
@@ -2290 +2290 @@
             return Bs3Cg1EncodeNext_BS3CG1ENC_MODRM_VqZxReg_WO_Nq(pThis, iEncoding);
 
-        case BS3CG1ENC_MODRM_Gv_Ma:
-            return Bs3Cg1EncodeNext_BS3CG1ENC_MODRM_Gv_Ma(pThis, iEncoding);
+        case BS3CG1ENC_MODRM_Gv_RO_Ma:
+            return Bs3Cg1EncodeNext_BS3CG1ENC_MODRM_Gv_RO_Ma(pThis, iEncoding);
 
         case BS3CG1ENC_MODRM_Mb_RO:
@@ -2390 +2390 @@
             break;
 
-        case BS3CG1ENC_MODRM_Gv_Ma:
+        case BS3CG1ENC_MODRM_Gv_RO_Ma:
             pThis->iRmOp             = 1;
             pThis->iRegOp            = 0;
@@ -2566 +2566 @@
     {
         case BS3CG1ENC_MODRM_Gb_Eb:
-        case BS3CG1ENC_MODRM_Gv_Ma:
+        case BS3CG1ENC_MODRM_Gv_RO_Ma:
         case BS3CG1ENC_FIXED:
             return BS3CG1ENC_FIXED;

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-generated-1.h

@@ -60 +60 @@
     BS3CG1OP_Gb,
     BS3CG1OP_Gv,
+    BS3CG1OP_Gv_RO,
     BS3CG1OP_Nq,
     BS3CG1OP_Pq_WO,
@@ -121 +122 @@
     BS3CG1ENC_MODRM_Gb_Eb,
     BS3CG1ENC_MODRM_Gv_Ev,
-    BS3CG1ENC_MODRM_Gv_Ma, /**< bound instruction */
+    BS3CG1ENC_MODRM_Gv_RO_Ma, /**< bound instruction */
     BS3CG1ENC_MODRM_Pq_WO_Uq,
     BS3CG1ENC_MODRM_Vq_WO_UqHi,