Changeset 66820 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

May 8, 2017 3:57:37 PM (8 years ago)

Author:

vboxsync

Message:

ValidationKit: teach the sheriff to draw the right conclusions from an installer running into a timeout, plus minor typo and other cleanups

Location:

trunk/src/VBox/ValidationKit

Files:

• testboxscript/win/readme.txt (modified) (2 diffs)
• testmanager/batch/virtual_test_sheriff.py (modified) (7 diffs)
• testmanager/core/testresults.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testboxscript/win/readme.txt

@@ -120 +120 @@
     Level Authentication" is not checked or rdesktop can't access it.
 
+    W10: Make old rdesktop connect:
+         \HKLM\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp\SecurityLayer
+         Change DWORD Hex '2' -> '1'
+
 23b. While you're in "System Properties", in the "Hardware" tab, button
     "Driver Signing" tell it to ignore logo testing requirements.
@@ -135 +139 @@
 
     W10: Find startup folder by hitting Win+R and entering "shell:startup".
-    W10: Make old rdesktop connect:
-         \HKLM\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp\SecurityLayer
-         Change DWORD Hex '2' -> '1'
 
 28. If this is an Intel box and the CPU is capable of Nested Paging, edit C:\autoexec-testbox.cmd

trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py

@@ -470 +470 @@
     ktReason_Host_Reboot_OSX_Watchdog_Timeout          = ( 'Host Reboot',       'OSX Watchdog Timeout' );
     ktReason_Host_Modprobe_Failed                      = ( 'Host',              'Modprobe failed' );
+    ktReason_Host_Install_Hang                         = ( 'Host',              'Install hang' );
     ktReason_Networking_Nonexistent_host_nic           = ( 'Networking',        'Nonexistent host networking interface' );
     ktReason_OSInstall_GRUB_hang                       = ( 'O/S Install',       'GRUB hang' );
@@ -616 +617 @@
 
     @staticmethod
-    def findAndReturnResetOfLine(sHaystack, sNeedle):
+    def findAndReturnRestOfLine(sHaystack, sNeedle):
         """
         Looks for sNeedle in sHaystack.
@@ -634 +635 @@
 
     @staticmethod
-    def findInAnyAndReturnResetOfLine(asHaystacks, sNeedle):
+    def findInAnyAndReturnRestOfLine(asHaystacks, sNeedle):
         """
         Looks for sNeedle in zeroe or more haystacks (asHaystack).
@@ -641 +642 @@
         """
         for sHaystack in asHaystacks:
-            sRet = VirtualTestSheriff.findAndReturnResetOfLine(sHaystack, sNeedle);
+            sRet = VirtualTestSheriff.findAndReturnRestOfLine(sHaystack, sNeedle);
             if sRet is not None:
                 return sRet;
@@ -673 +674 @@
         an uninstall first and will be seeing similar issues to the uninstall.
         """
-        _ = fInstall;
+
+        if fInstall and oFailedResult.enmStatus == TestSetData.ksTestStatus_TimedOut:
+            oCaseFile.noteReasonForId(self.ktReason_Host_Install_Hang, oFailedResult.idTestResult)
+            return True;
 
         atSimple = self.katSimpleInstallUninstallMainLogReasons;
@@ -840 +844 @@
           'Error: failed to start machine. Error message: Not supported. (VERR_NOT_SUPPORTED)' ),
         ( False, ktReason_Unknown_VM_Crash,                         'txsDoConnectViaTcp: Machine state: Aborted' ),
-        ( True,  ktReason_Host_Modprobe_Failed,                     'Kernel driver not installed' )
+        ( True,  ktReason_Host_Modprobe_Failed,                     'Kernel driver not installed' )
     ];
 
@@ -927 +931 @@
             # Look for BSODs. Some stupid stupid inconsistencies in reason and log messages here, so don't try prettify this.
             #
-            sDetails = self.findInAnyAndReturnResetOfLine([ sVMLog, sResultLog ],
-                                                          'GIM: HyperV: Guest indicates a fatal condition! P0=');
+            sDetails = self.findInAnyAndReturnRestOfLine([ sVMLog, sResultLog ],
+                                                         'GIM: HyperV: Guest indicates a fatal condition! P0=');
             if sDetails is not None:
                 # P0=%#RX64 P1=%#RX64 P2=%#RX64 P3=%#RX64 P4=%#RX64 "

trunk/src/VBox/ValidationKit/testmanager/core/testresults.py

@@ -211 +211 @@
     def getListOfFailures(self):
         """
-        Get a list of test results insances actually contributing to cErrors.
-
-        Returns a list of TestResultDataEx insance from this tree. (shared!)
+        Get a list of test results instances actually contributing to cErrors.
+
+        Returns a list of TestResultDataEx instance from this tree. (shared!)
         """
         # Check each child (if any).