Changeset 6683 in vbox

Timestamp:

Jan 31, 2008 7:58:39 PM (17 years ago)

Author:

vboxsync

Message:

r=bird: see @todo. spaces.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/VBoxFBQuartz2D.cpp (modified) (7 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxFBQuartz2D.cpp

@@ +1 @@
+/* $Id$ */
 /** @file
- *
- * VBox frontends: Qt GUI ("VirtualBox"):
- * Quartz2D framebuffer implementation
+ * Qt GUI (aka VirtualBox) - Quartz2D framebuffer implementation.
  */
 
@@ -78 +77 @@
         return E_POINTER;
 
+    /** @todo r=bird: Is this thread safe? If I remember the code flow correctly, the
+     * GUI thread could be happily jogging along paintEvent now on another cpu core.
+     * This function is called on the EMT (emulation thread). Which means, blocking
+     * execution waiting for a lock is out of the question. A quick solution using
+     * ASMAtomic(Cmp)XchgPtr and a struct { cAllocated; cRects; aRects[1]; }
+     * *mRegion, *mUnusedRegion; should suffice (and permit you to reuse allocations). */
     RTMemFree (mRegionRects);
     mRegionCount = 0;
-    mRegionRects = static_cast<CGRect*>(RTMemAlloc (sizeof (CGRect) * aCount));
+    mRegionRects = static_cast <CGRect*> (RTMemAlloc (sizeof (CGRect) * aCount));
 
     QRegion reg;
@@ -171 +176 @@
 
     /* Create the context to draw on */
-    WindowPtr window = static_cast<WindowPtr>(mView->viewport()->handle());
+    WindowPtr window = static_cast <WindowPtr> (mView->viewport()->handle());
     SetPortWindowPort (window);
     CGContextRef ctx;
     QDBeginCGContext (GetWindowPort (window), &ctx);
     /* We handle the seamless mode as a special case. */
-    if (static_cast<VBoxConsoleWnd*>(pMain)->isTrueSeamless())
+    if (static_cast <VBoxConsoleWnd*> (pMain)->isTrueSeamless())
     {
         /* Here we paint the windows without any wallpaper.
@@ -210 +215 @@
         /* At this point draw the real vm image */
         CGContextDrawImage (ctx, QRectToCGRect (Q2DViewRect), subImage);
-    }else
+    }
+    else
     {
         /* Here we paint if we didn't care about any masks */
@@ -223 +229 @@
         /* Ok, for more performance we set a clipping path of the
          * regions given by this paint event. */
-        QMemArray<QRect> a = pe->region().rects();
+        QMemArray <QRect> a = pe->region().rects();
         if (a.size() > 0)
         {
@@ -278 +284 @@
      * Mac OS X supports 16 bit also but not in the 565 mode. So we could use
      * 32 bit only. */
-    if (re->pixelFormat() == FramebufferPixelFormat_FOURCC_RGB &&
-        re->bitsPerPixel() == 32)
+    if (   re->pixelFormat() == FramebufferPixelFormat_FOURCC_RGB
+        && re->bitsPerPixel() == 32)
     {
 //        printf ("VRAM\n");
@@ -302 +308 @@
                                kCGImageAlphaNoneSkipFirst | kCGBitmapByteOrder32Little, dp, 0, false,
                                kCGRenderingIntentDefault);
-        mDataAddress = static_cast<uchar*>(mBitmapData);
+        mDataAddress = static_cast <uchar*> (mBitmapData);
         CGDataProviderRelease (dp);
     }