Changeset 67008 in vbox

Timestamp:

May 22, 2017 11:56:11 AM (8 years ago)

Author:

vboxsync

Message:

IEM: movdqa Vdq,Wdq (0x66 0x0f 0x6f) tests.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h

@@ -3569 +3569 @@
          * @oppfx       0x66
          * @opcpuid     sse2
-         * @opgroup     og_sse2_simdint_datamov
+         * @opgroup     og_sse2_simdint_datamove
          * @opxcpttype  5
          * @optest      64-bit / op1=1 op2=2   -> op1=2
@@ -3618 +3618 @@
          * @oppfx       0x66
          * @opcpuid     sse2
-         * @opgroup     og_sse2_simdint_datamov
+         * @opgroup     og_sse2_simdint_datamove
          * @opxcpttype  5
          * @opfunction  iemOp_movd_q_Vy_Ey
@@ -3669 +3669 @@
  * @opcode      0x6f
  * @oppfx       none
- * @opcpuid     sse2
+ * @opcpuid     mmx
  * @opgroup     og_mmx_datamove
  * @opxcpttype  5
  * @optest      op1=1 op2=2   -> op1=2   ftw=0xff
  * @optest      op1=0 op2=-42 -> op1=-42 ftw=0xff
- * @oponly
  */
 FNIEMOP_DEF(iemOp_movq_Pq_Qq)
 {
-    uint8_t bRm; IEM_OPCODE_GET_NEXT_U8(&bRm);
     IEMOP_MNEMONIC2(RM, MOVD, movd, Pq_WO, Qq, DISOPTYPE_HARMLESS, IEMOPHINT_IGNORES_OP_SIZES);
+    uint8_t bRm; IEM_OPCODE_GET_NEXT_U8(&bRm);
     if ((bRm & X86_MODRM_MOD_MASK) == (3 << X86_MODRM_MOD_SHIFT))
     {
@@ -3723 +3722 @@
 }
 
-/** Opcode 0x66 0x0f 0x6f - movdqa Vx, Wx */
-FNIEMOP_DEF(iemOp_movdqa_Vx_Wx)
-{
-    uint8_t bRm; IEM_OPCODE_GET_NEXT_U8(&bRm);
-    IEMOP_MNEMONIC(movdqa_Vdq_Wdq, "movdqa Vdq,Wdq");
+/**
+ * @opcode      0x6f
+ * @oppfx       0x66
+ * @opcpuid     sse2
+ * @opgroup     og_sse2_simdint_datamove
+ * @opxcpttype  1
+ * @optest      op1=1 op2=2   -> op1=2
+ * @optest      op1=0 op2=-42 -> op1=-42
+ */
+FNIEMOP_DEF(iemOp_movdqa_Vdq_Wdq)
+{
+    IEMOP_MNEMONIC2(RM, MOVDQA, movdqa, Vdq_WO, Wdq, DISOPTYPE_HARMLESS, IEMOPHINT_IGNORES_OP_SIZES);
+    uint8_t bRm; IEM_OPCODE_GET_NEXT_U8(&bRm);
     if ((bRm & X86_MODRM_MOD_MASK) == (3 << X86_MODRM_MOD_SHIFT))
     {
@@ -3735 +3742 @@
         IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX();
         IEM_MC_BEGIN(0, 0);
+
         IEM_MC_MAYBE_RAISE_SSE2_RELATED_XCPT();
         IEM_MC_ACTUALIZE_SSE_STATE_FOR_CHANGE();
+
         IEM_MC_COPY_XREG_U128(((bRm >> X86_MODRM_REG_SHIFT) & X86_MODRM_REG_SMASK) | pVCpu->iem.s.uRexReg,
                               (bRm & X86_MODRM_RM_MASK) | pVCpu->iem.s.uRexB);
@@ -3755 +3764 @@
         IEM_MC_MAYBE_RAISE_SSE2_RELATED_XCPT();
         IEM_MC_ACTUALIZE_SSE_STATE_FOR_CHANGE();
+
         IEM_MC_FETCH_MEM_U128_ALIGN_SSE(u128Tmp, pVCpu->iem.s.iEffSeg, GCPtrEffSrc);
         IEM_MC_STORE_XREG_U128(((bRm >> X86_MODRM_REG_SHIFT) & X86_MODRM_REG_SMASK) | pVCpu->iem.s.uRexReg, u128Tmp);
@@ -9185 +9195 @@
     /* 0x6d */  iemOp_InvalidNeedRM,        iemOp_punpckhqdq_Vx_W,      iemOp_InvalidNeedRM,        iemOp_InvalidNeedRM,
     /* 0x6e */  iemOp_movd_q_Pd_Ey,         iemOp_movd_q_Vy_Ey,         iemOp_InvalidNeedRM,        iemOp_InvalidNeedRM,
-    /* 0x6f */  iemOp_movq_Pq_Qq,           iemOp_movdqa_Vx_Wx,         iemOp_movdqu_Vx_Wx,         iemOp_InvalidNeedRM,
+    /* 0x6f */  iemOp_movq_Pq_Qq,           iemOp_movdqa_Vdq_Wdq,       iemOp_movdqu_Vx_Wx,         iemOp_InvalidNeedRM,
 
     /* 0x70 */  iemOp_pshufw_Pq_Qq_Ib,      iemOp_pshufd_Vx_Wx_Ib,      iemOp_pshufhw_Vx_Wx_Ib,     iemOp_pshuflw_Vx_Wx_Ib,