Changeset 67319 in vbox for trunk/src/VBox/Additions/x11

Timestamp:

Jun 9, 2017 1:11:48 PM (7 years ago)

Author:

vboxsync

Message:

bugref:8533: Additions/x11: fully support VMSVGA
Allow VBoxClient services to daemonise without providing a pidfile.

Up until now VBoxClient service processes would be made into daemons (unless
the user overrid this) if they provided a name for creating a pidfile. We
add an additional member to the service description structure which is a
boolean specifying whether the service should be daemonised anyway. The
vmsvga service does not need a pidfile as it will use guest capability
acquiring to prevent multiple copies running, but should still be a daemon.
As the new structure member is at the end, it will automatically be zero
(false) for existing services which do not set it.

Location:

trunk/src/VBox/Additions/x11/VBoxClient

Files:

• VBoxClient.h (modified) (2 diffs)
• main.cpp (modified) (1 diff)

trunk/src/VBox/Additions/x11/VBoxClient/VBoxClient.h

@@ -42 +42 @@
 struct VBCLSERVICE
 {
-    /** Get the services default path to pidfile, relative to $HOME */
+    /** Get the services default path to pidfile, relative to $HOME.  Optional */
     /** @todo Should this also have a component relative to the X server number?
      */
@@ -55 +55 @@
      */
     void (*cleanup)(struct VBCLSERVICE **ppInterface);
+    /** Should the service daemonise?  Only checked if @a getPidFilePath is NULL. */
+    /** @todo clean this up along with the pidfile handling. */
+    bool fDaemonise;
 };
 

trunk/src/VBox/Additions/x11/VBoxClient/main.cpp

@@ -329 +329 @@
         if (RT_FAILURE(rc))
             VBClFatalError(("Creating PID file path failed: %Rrc\n", rc));
+    }
+    if ((*g_pService)->getPidFilePath || (*g_pService)->fDaemonise)
+    {
         if (fDaemonise)
             rc = VbglR3Daemonize(false /* fNoChDir */, false /* fNoClose */, fRespawn, &cRespawn);