Changeset 67464 in vbox for trunk/src/VBox/Storage

Timestamp:

Jun 19, 2017 10:08:36 AM (8 years ago)

Author:

vboxsync

Message:

VD.cpp: VDGetFormat: Here be dragons. Killed the one named VERR_EOF, but can imagine a there are a lot more lurking around...

File:

• trunk/src/VBox/Storage/VD.cpp (modified) (2 diffs)

trunk/src/VBox/Storage/VD.cpp

@@ -5467 +5467 @@
                  * and signal success - the actual open will of course fail,
                  * but that will create a really sensible error message. */
+
+                    /** @todo r=bird: this bit of code is _certifiably_ _insane_ as it allows
+                     *        simple stuff like VERR_EOF to pass thru.  I've just amended it with
+                     *        disallowing VERR_EOF too, but someone needs to pick up the courage to
+                     *        fix this stuff properly or at least update the docs!
+                     *        (Parallels returns VERR_EOF, btw.) */
+
                 ||  (   rc != VERR_VD_GEN_INVALID_HEADER
                      && rc != VERR_VD_VDI_INVALID_HEADER
@@ -5478 +5485 @@
                      && rc != VERR_VD_RAW_SIZE_FLOPPY_TOO_BIG
                      && rc != VERR_VD_PARALLELS_INVALID_HEADER
-                     && rc != VERR_VD_DMG_INVALID_HEADER))
+                     && rc != VERR_VD_DMG_INVALID_HEADER
+                     && rc != VERR_EOF /* bird for viso */
+                        ))
             {
                 /* Copy the name into the new string. */