Changeset 67587 in vbox

Timestamp:

Jun 23, 2017 4:18:49 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

116345

Message:

DevVGA: Add a few missing checks which skip the VRAM alias mapping to the LFB when the PCI BAR isn't set up (i.e. the LFB physical address is 0, conflicting with system RAM). Performance is very bad in this case, but it's not an expected use case to have incorrectly initialized BARs.

File:

• trunk/src/VBox/Devices/Graphics/DevVGA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA.cpp

@@ -1240 +1240 @@
         /* If all planes are accessible, then map the page to the frame buffer and make it writable. */
         if (   (pThis->sr[2] & 3) == 3
-            && !vga_is_dirty(pThis, addr))
+            && !vga_is_dirty(pThis, addr)
+            && pThis->GCPhysVRAM)
         {
             /** @todo only allow read access (doesn't work now) */
@@ -1345 +1346 @@
             /* If all planes are accessible, then map the page to the frame buffer and make it writable. */
             if (   (pThis->sr[2] & 3) == 3
-                && !vga_is_dirty(pThis, addr))
+                && !vga_is_dirty(pThis, addr)
+                && pThis->GCPhysVRAM)
             {
                 STAM_COUNTER_INC(&pThis->StatMapPage);
@@ -5816 +5818 @@
 
     /*
-     * Reset the LBF mapping.
+     * Reset the LFB mapping.
      */
     pThis->fLFBUpdated = false;