Changeset 67613 in vbox

Timestamp:

Jun 26, 2017 4:38:43 PM (8 years ago)

Author:

vboxsync

Message:

DevHDA: fixed sanity checks

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -1426 +1426 @@
 {
     AssertPtrReturn(pThis, NULL);
-    AssertReturn(uSD <= HDA_MAX_STREAMS, NULL);
+    AssertReturn(uSD < HDA_MAX_STREAMS, NULL);
 
     if (uSD >= HDA_MAX_STREAMS)
@@ -1467 +1467 @@
 DECLINLINE(PDMAUDIODIR) hdaGetDirFromSD(uint8_t uSD)
 {
-    AssertReturn(uSD <= HDA_MAX_STREAMS, PDMAUDIODIR_UNKNOWN);
+    AssertReturn(uSD < HDA_MAX_STREAMS, PDMAUDIODIR_UNKNOWN);
 
     if (uSD < HDA_MAX_SDI)
@@ -2023 +2023 @@
     AssertPtrReturnVoid(pThis);
     AssertPtrReturnVoid(pStream);
-    AssertReturnVoid(uSD <= HDA_MAX_STREAMS);
+    AssertReturnVoid(uSD < HDA_MAX_STREAMS);
 
 # ifdef VBOX_STRICT
@@ -5321 +5321 @@
 
     /* Sanity checks. */
-    Assert(pStream->u8SD <= HDA_MAX_STREAMS);
+    Assert(pStream->u8SD < HDA_MAX_STREAMS);
     Assert(pStream->u64BDLBase);
     Assert(pStream->u32CBL);
@@ -5965 +5965 @@
     int rc = SSMR3PutU8(pSSM, pStrm->u8SD);
     AssertRCReturn(rc, rc);
-    Assert(pStrm->u8SD <= HDA_MAX_STREAMS);
+    Assert(pStrm->u8SD < HDA_MAX_STREAMS);
 
     rc = SSMR3PutStructEx(pSSM, &pStrm->State, sizeof(HDASTREAMSTATE), 0 /*fFlags*/, g_aSSMStreamStateFields7, NULL);