Changeset 67875 in vbox

Timestamp:

Jul 10, 2017 12:11:37 PM (8 years ago)

Author:

vboxsync

Message:

VMM/HMSVMR0: Fix regression with hypercalls introduced in r113826 (Affected Hyper-V debugging which uses
hypercall). Premature updating of the RIP caused us to guru rather than performing the hypercall.

File:

• trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -5395 +5395 @@
     if (RT_SUCCESS(rcStrict))
     {
-        if (!fRipUpdated)
+        /* Only update the RIP if we're continuing guest execution and not
+           in the case of say VINF_GIM_R3_HYPERCALL. */
+        if (   rcStrict == VINF_SUCCESS
+            && !fRipUpdated)
+        {
             hmR0SvmAdvanceRipHwAssist(pVCpu, pCtx, 3 /* cbInstr */);
+        }
 
         /* If the hypercall or TPR patching changes anything other than guest's general-purpose registers,