Changeset 67956 in vbox

Timestamp:

Jul 13, 2017 9:31:26 PM (8 years ago)

Author:

vboxsync

Message:

VMMR0: todo

Location:

trunk/src/VBox/VMM/VMMR0

Files:

• GVMMR0.cpp (modified) (2 diffs)
• VMMR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/GVMMR0.cpp

@@ -1183 +1183 @@
                     VERR_WRONG_ORDER);
 
-    uint32_t hGVM = pGVM->hSelf;
+    uint32_t        hGVM = pGVM->hSelf;
     AssertReturn(hGVM != NIL_GVM_HANDLE, VERR_INVALID_HANDLE);
     AssertReturn(hGVM < RT_ELEMENTS(pGVMM->aHandles), VERR_INVALID_HANDLE);
 
-    PGVMHANDLE pHandle = &pGVMM->aHandles[hGVM];
+    PGVMHANDLE      pHandle = &pGVMM->aHandles[hGVM];
     AssertReturn(pHandle->pVM == pVM, VERR_NOT_OWNER);
 
-    RTPROCESS      ProcId = RTProcSelf();
-    RTNATIVETHREAD hSelf  = RTThreadNativeSelf();
+    RTPROCESS       ProcId = RTProcSelf();
+    RTNATIVETHREAD  hSelf  = RTThreadNativeSelf();
     AssertReturn(   (   pHandle->hEMT0  == hSelf
                      && pHandle->ProcId == ProcId)
@@ -1203 +1203 @@
     int rc = gvmmR0CreateDestroyLock(pGVMM);
     AssertRC(rc);
+
+/** @todo Check that all other EMTs have said bye-bye. */
+
 
     /* Be careful here because we might theoretically be racing someone else cleaning up. */

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -2010 +2010 @@
  *
  * @returns VBox status code.
+ * @param   pGVM            The global (ring-0) VM structure.
  * @param   pVM             The cross context VM structure.
  * @param   idCpu           Virtual CPU ID argument. Must be NIL_VMCPUID if pVM