Changeset 67988 in vbox

Timestamp:

Jul 17, 2017 11:30:28 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

116997

Message:

GVMMR0: Moved the VMMR0ThreadCtxHookDestroyForEmt calls to the right place so we don't leak this on abends.

File:

• trunk/src/VBox/VMM/VMMR0/GVMMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/GVMMR0.cpp

@@ -1226 +1226 @@
             gvmmR0CreateDestroyUnlock(pGVMM);
 
-            /** @todo this _must_ be the wrong place.   */
-            for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
-            {
-                /** @todo Can we busy wait here for all thread-context hooks to be
-                 *        deregistered before releasing (destroying) it? Only until we find a
-                 *        solution for not deregistering hooks everytime we're leaving HMR0
-                 *        context. */
-                VMMR0ThreadCtxHookDestroyForEmt(&pVM->aCpus[idCpu]);
-            }
-
             SUPR0ObjRelease(pvObj, pHandle->pSession);
         }
@@ -1277 +1267 @@
 
     GMMR0CleanupVM(pGVM);
+
+    AssertCompile((uintptr_t)NIL_RTTHREADCTXHOOK == 0); /* Depends on zero initialized memory working for NIL at the moment. */
+    for (VMCPUID idCpu = 0; idCpu < pGVM->cCpus; idCpu++)
+    {
+        /** @todo Can we busy wait here for all thread-context hooks to be
+         *        deregistered before releasing (destroying) it? Only until we find a
+         *        solution for not deregistering hooks everytime we're leaving HMR0
+         *        context. */
+        VMMR0ThreadCtxHookDestroyForEmt(&pGVM->pVM->aCpus[idCpu]);
+    }
 }