Changeset 68097 in vbox for trunk/src/VBox/Additions/WINNT/VBoxCredProv

Timestamp:

Jul 24, 2017 1:33:51 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

117145

Message:

VBoxCredProv/VBoxCredProvCredential.cpp: Simplified VBoxCredProvCredential::GetStringValue(), updated comments, logging tweaks.

File:

• trunk/src/VBox/Additions/WINNT/VBoxCredProv/VBoxCredProvCredential.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/WINNT/VBoxCredProv/VBoxCredProvCredential.cpp

@@ -453 +453 @@
                         pwszField,
 #else
-                        L"XXX" /* Don't show any actual values in release mode. */,
+                        /* Don't show any passwords in release mode. */
+                        dwFieldID == VBOXCREDPROV_FIELDID_PASSWORD ? L"XXX" : pwszField,
 #endif
                         fNotifyUI, hr);
@@ -565 +566 @@
     }
 
-    /* If credentials already were retrieved (also by a former call), don't try to retrieve new ones
-     * and just report back the already retrieved ones. */
     if (m_fHaveCreds)
     {
-        VBoxCredProvVerbose(0, "VBoxCredProvCredential::RetrieveCredentials: Credentials already retrieved\n");
+        VBoxCredProvVerbose(0, "VBoxCredProvCredential::RetrieveCredentials: Setting fields\n");
 
         setField(VBOXCREDPROV_FIELDID_USERNAME,   pwszUser,     true /* fNotifyUI */);
@@ -881 +880 @@
 {
     HRESULT hr;
-    if (   dwFieldID < VBOXCREDPROV_NUM_FIELDS
-        && ppwszString)
+
+    PWSTR pwszString = NULL;
+
+    if (dwFieldID < VBOXCREDPROV_NUM_FIELDS)
     {
         switch (dwFieldID)
         {
             case VBOXCREDPROV_FIELDID_SUBMIT_BUTTON:
+            {
                 /* Fill in standard value to make Winlogon happy. */
-                hr = SHStrDupW(L"Submit", ppwszString);
+                hr = SHStrDupW(L"Submit", &pwszString);
                 break;
+            }
 
             default:
+            {
                 if (   m_apwszFields[dwFieldID]
                     && RTUtf16Len(m_apwszFields[dwFieldID]))
-                    hr = SHStrDupW(m_apwszFields[dwFieldID], ppwszString);
+                {
+                    hr = SHStrDupW(m_apwszFields[dwFieldID], &pwszString);
+                }
                 else /* Fill in an empty value. */
-                    hr = SHStrDupW(L"", ppwszString);
+                    hr = SHStrDupW(L"", &pwszString);
                 break;
+            }
         }
     }
@@ -903 +910 @@
         hr = E_INVALIDARG;
 
-    VBoxCredProvVerbose(0, "VBoxCredProvCredential::GetStringValue: m_fIsSelected=%RTbool, dwFieldID=%ld, ppwszString=%ls, hr=%Rhrc\n",
+    VBoxCredProvVerbose(0, "VBoxCredProvCredential::GetStringValue: m_fIsSelected=%RTbool, dwFieldID=%ld, pwszString=%ls, hr=%Rhrc\n",
                         m_fIsSelected, dwFieldID,
 #ifdef DEBUG
-                        ppwszString ? *ppwszString : L"<NULL>",
-#else /* Never show any (sensitive) data in release mode! */
-                        L"XXX",
+                        pwszString ? pwszString : L"<NULL>",
+#else
+                        /* Don't show any passwords in release mode. */
+                        dwFieldID == VBOXCREDPROV_FIELDID_PASSWORD ? L"XXX" : (pwszString ? pwszString : L"<NULL>"),
 #endif
                         hr);
+
+    if (ppwszString)
+    {
+        *ppwszString = pwszString;
+    }
+    else if (pwszString)
+        CoTaskMemFree(pwszString);
+
     return hr;
 }