Changeset 68101 in vbox for trunk/src/VBox/Additions

Timestamp:

Jul 25, 2017 9:33:10 AM (7 years ago)

Author:

vboxsync

Message:

Shared folders: stop supporting legacy host code on Linux, add Windows todo.

bugref:8524: Additions/linux: play nicely with distribution-installed Additions
Using physical page lists in HGCM was added in VirtualBox 3.1, and the Linux
and Windows shared folder Additions still have code paths for supporting
older versions. Remove this on Linux and add a todo to Windows to remove it.
This removes all shared folder driver dependencies on the guest library other
than HGCM.

Signed-off-by: Hans de Goede <hdegoede@…>
Reworked by Oracle.

Location:

trunk/src/VBox/Additions

Files:

• WINNT/SharedFolders/driver/file.c (modified) (1 diff)
• linux/sharedfolders/regops.c (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/SharedFolders/driver/file.c

@@ -92 +92 @@
     uint32_t cbIO;
 
+    /** @todo Remove the test and the fall-back path.  VbglR0CanUsePhysPageList()
+     *        returns true for any host version after 3.0, i.e. further back than
+     *        we support. */
     if (VbglR0CanUsePhysPageList())
     {

trunk/src/VBox/Additions/linux/sharedfolders/regops.c

@@ -233 +233 @@
         }
 
-#if 1
-        if (VbglR0CanUsePhysPageList())
-        {
-            err = VbglR0SfWritePhysCont(&client_handle, &sf_g->map, sf_r->handle,
-                                        pos, &nwritten, tmp_phys);
-            err = RT_FAILURE(err) ? -EPROTO : 0;
-        }
-        else
-#endif
-            err = sf_reg_write_aux(__func__, sf_g, sf_r, tmp, &nwritten, pos);
+        err = VbglR0SfWritePhysCont(&client_handle, &sf_g->map, sf_r->handle,
+                                    pos, &nwritten, tmp_phys);
         if (err)
             goto fail;