Changeset 68199 in vbox

Timestamp:

Jul 31, 2017 12:32:17 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

117296

Message:

FE/Qt: bugref:8900: UISelectorWindow: A bit of cleanup/rework.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/selector

Files:

• UISelectorWindow.cpp (modified) (4 diffs)
• UISelectorWindow.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/selector/UISelectorWindow.cpp

@@ -206 +206 @@
     UIVMItem *pItem = currentItem();
 
-    /* Determine which menu to show: */
-    m_pGroupMenuAction->setVisible(m_pPaneChooser->isSingleGroupSelected());
-    m_pMachineMenuAction->setVisible(!m_pPaneChooser->isSingleGroupSelected());
-    if (m_pGroupMenuAction->isVisible())
-    {
-        foreach (UIAction *pAction, m_machineActions)
-            pAction->hideShortcut();
-        foreach (UIAction *pAction, m_groupActions)
-            pAction->showShortcut();
-    }
-    else if (m_pMachineMenuAction->isVisible())
-    {
-        foreach (UIAction *pAction, m_groupActions)
-            pAction->hideShortcut();
-        foreach (UIAction *pAction, m_machineActions)
-            pAction->showShortcut();
-    }
-
+    /* Update action visibility: */
+    updateActionsVisibility();
     /* Update action appearance: */
     updateActionsAppearance();
@@ -1699 +1683 @@
         m_pToolBar->setContextMenuPolicy(Qt::CustomContextMenu);
         m_pToolBar->setToolButtonStyle(Qt::ToolButtonTextUnderIcon);
-        // TODO: Get red of hard-coded stuff:
+        // TODO: Get rid of hard-coded stuff:
         const QSize toolBarIconSize = m_pToolBar->iconSize();
         if (toolBarIconSize.width() < 32 || toolBarIconSize.height() < 32)
@@ -1931 +1915 @@
     connect(m_pPaneToolsMachine, SIGNAL(sigLinkClicked(const QString&, const QString&, const QString&)),
             this, SLOT(sltOpenMachineSettingsDialog(const QString&, const QString&, const QString&)));
-
 
     /* Global event handlers: */
@@ -2085 +2068 @@
             vboxGlobal().launchMachine(machine, enmItemLaunchMode);
         }
+}
+
+void UISelectorWindow::updateActionsVisibility()
+{
+    /* Determine whether Machine or Group menu should be shown at all: */
+    const bool fMachineMenuShown = !m_pPaneChooser->isSingleGroupSelected();
+    m_pMachineMenuAction->setVisible(fMachineMenuShown);
+    m_pGroupMenuAction->setVisible(!fMachineMenuShown);
+
+    /* Hide action shortcuts: */
+    if (!fMachineMenuShown)
+        foreach (UIAction *pAction, m_machineActions)
+            pAction->hideShortcut();
+    if (fMachineMenuShown)
+        foreach (UIAction *pAction, m_groupActions)
+            pAction->hideShortcut();
+
+    /* Show what should be shown: */
+    if (fMachineMenuShown)
+        foreach (UIAction *pAction, m_machineActions)
+            pAction->showShortcut();
+    if (!fMachineMenuShown)
+        foreach (UIAction *pAction, m_groupActions)
+            pAction->showShortcut();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/selector/UISelectorWindow.h

@@ -267 +267 @@
     /** @name Action update stuff.
       * @{ */
+        /** Performs update of actions visibility. */
+        void updateActionsVisibility();
         /** Performs update of actions appearance. */
         void updateActionsAppearance();
@@ -325 +327 @@
     /** Holds the Chooser-pane instance. */
     UIGChooser         *m_pPaneChooser;
-    /** Holds the Tools-pane instance. */
+    /** Holds the Machine Tools-pane instance. */
     UIToolsPaneMachine *m_pPaneToolsMachine;