Changeset 68358 in vbox

Timestamp:

Aug 9, 2017 3:25:45 PM (7 years ago)

Author:

vboxsync

Message:

Audio/DrvHostPulseAudio.cpp: Removed PULSEAUDIO_ASYNC and put the code within DEBUG defines. Not needed otherwise.

File:

• trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp (modified) (9 diffs)

trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp

@@ -46 +46 @@
 #define VBOX_PULSEAUDIO_MAX_LOG_REL_ERRORS 32 /** @todo Make this configurable thru driver options. */
 
-/* Whether to use PulseAudio's asynchronous handling or not. */
-//#define PULSEAUDIO_ASYNC /** @todo Make this configurable thru driver options. */
-
 #ifndef PA_STREAM_NOFLAGS
 # define PA_STREAM_NOFLAGS (pa_context_flags_t)0x0000U /* since 0.9.19 */
@@ -66 +63 @@
     ( (PDRVHOSTPULSEAUDIO)((uintptr_t)pInterface - RT_OFFSETOF(DRVHOSTPULSEAUDIO, IHostAudio)) )
 
-#define PULSEAUDIO_ASYNC
 
 /*********************************************************************************************************************************
@@ -191 +187 @@
 static int  paEnumerate(PDRVHOSTPULSEAUDIO pThis, PPDMAUDIOBACKENDCFG pCfg, uint32_t fEnum);
 static int  paError(PDRVHOSTPULSEAUDIO pThis, const char *szMsg);
+#ifdef DEBUG
 static void paStreamCbUnderflow(pa_stream *pStream, void *pvContext);
-#ifdef PULSEAUDIO_ASYNC
- static void paStreamCbReqWrite(pa_stream *pStream, size_t cbLen, void *pvContext);
+static void paStreamCbReqWrite(pa_stream *pStream, size_t cbLen, void *pvContext);
 #endif
 static void paStreamCbSuccess(pa_stream *pStream, int fSuccess, void *pvContext);
@@ -407 +403 @@
 
 
-#ifdef PULSEAUDIO_ASYNC
+#ifdef DEBUG
 static void paStreamCbReqWrite(pa_stream *pStream, size_t cbLen, void *pvContext)
 {
@@ -421 +417 @@
     Log2Func(("Requested %zu bytes -- Current latency is %RU64ms\n", cbLen, usec / 1000));
 }
-#endif /* PULSEAUDIO_ASYNC */
 
 
@@ -448 +443 @@
     }
 
-#ifdef LOG_ENABLED
+# ifdef LOG_ENABLED
     pa_usec_t curLatencyUs = 0;
     pa_stream_get_latency(pStream, &curLatencyUs, NULL /* Neg */);
@@ -460 +455 @@
     Log2Func(("curPosWrite=%RU64ms, curTs=%RU64ms, curDelta=%RI64ms, curLatency=%RU64ms\n",
               curPosWritesUs / 1000, curTsUs / 1000, (((int64_t)curPosWritesUs - (int64_t)curTsUs) / 1000), curLatencyUs / 1000));
-#endif
-}
-
-
-#ifdef VBOX_STRICT
+# endif
+}
+
+
 static void paStreamCbOverflow(pa_stream *pStream, void *pvContext)
 {
@@ -471 +465 @@
     Log2Func(("Warning: Hit overflow\n"));
 }
-#endif
+#endif /* DEBUG */
 
 
@@ -528 +522 @@
         }
 
-#ifdef PULSEAUDIO_ASYNC
+#ifdef DEBUG
         pa_stream_set_write_callback       (pStream, paStreamCbReqWrite,     pStreamPA);
-#endif
         pa_stream_set_underflow_callback   (pStream, paStreamCbUnderflow,    pStreamPA);
-#ifdef VBOX_STRICT
         if (!fIn) /* Only for output streams. */
             pa_stream_set_overflow_callback(pStream, paStreamCbOverflow,     pStreamPA);