Changeset 68372 in vbox for trunk/src/VBox/Main

Timestamp:

Aug 10, 2017 2:00:06 PM (7 years ago)

Author:

vboxsync

Message:

Main/EbmlWriter.cpp: Only write cues element if any cue points are available. Needed for making mkvalidator happy. Additional logging.

File:

• trunk/src/VBox/Main/src-client/EbmlWriter.cpp (modified) (7 diffs)

trunk/src/VBox/Main/src-client/EbmlWriter.cpp

@@ -583 +583 @@
 
         pTrack->Audio.uHz     = uHz;
-        pTrack->Audio.csFrame = pTrack->Audio.uHz / (1000 /* s in ms */ / 20); /** @todo 20 ms of audio data. Make this configurable? */
+        pTrack->Audio.csFrame = pTrack->Audio.uHz / (1000 /* s in ms */ / 20 /* ms */); /** @todo 20 ms of audio data. Make this configurable? */
 
         OpusPrivData opusPrivData(uHz, cChannels);
@@ -681 +681 @@
                                  const void *a_pvData, size_t a_cbData, uint8_t a_fFlags)
     {
-        LogFunc(("SimpleBlock @ %RU64 (T%RU8, TS=%RU64, %zu bytes)\n",
-                 RTFileTell(m_Ebml.getFile()), a_pTrack->uTrack, a_uTimecode, a_cbData));
+        Log3Func(("SimpleBlock @ %RU64 (T%RU8, TS=%RU64, %zu bytes)\n",
+                  RTFileTell(m_Ebml.getFile()), a_pTrack->uTrack, a_uTimecode, a_cbData));
 
         /** @todo Mask out non-valid timecode bits, e.g. the upper 48 bits for a (default) 16-bit timecode. */
@@ -809 +809 @@
             Cluster.tcStart = tcPTS;
 
-        LogFunc(("tcPTSRaw=%RU64, tcPTS=%RU64, cbData=%RU64, uTimeStampMs=%RU64\n",
-                 tcPTSRaw, tcPTS, Cluster.cbData, uTimeStampMs));
-
         Cluster.tcLast = tcPTS;
 
@@ -844 +841 @@
 
             Cluster.fOpen      = true;
+            Cluster.uID        = a_pTrack->cTotalClusters;
             Cluster.tcStart    = tcPTS;
+            Cluster.tcLast     = Cluster.tcStart;
             Cluster.offCluster = RTFileTell(m_Ebml.getFile());
             Cluster.cBlocks    = 0;
             Cluster.cbData     = 0;
 
-            LogFunc(("[C%RU64] Start @ tc=%RU64 off=%RU64\n", a_pTrack->cTotalClusters, Cluster.tcStart, Cluster.offCluster));
+            LogFunc(("[C%RU64] Start @ tc=%RU64 off=%RU64\n", Cluster.uID, Cluster.tcStart, Cluster.offCluster));
 
             m_Ebml.subStart(MkvElem_Cluster)
@@ -857 +856 @@
         }
 
-        LogFunc(("tcPTS=%RU64, s=%RU64, e=%RU64\n", tcPTS, CurSeg.CurCluster.tcStart, CurSeg.CurCluster.tcLast));
-
         Cluster.cBlocks += 1;
         Cluster.cbData  += cbData;
+
+        Log2Func(("[C%RU64] tcBlock=%RU64, tcClusterStart=%RU64, tcClusterLast=%RU64, cbData=%zu\n",
+                  Cluster.uID, tcBlock, CurSeg.CurCluster.tcStart, CurSeg.CurCluster.tcLast, CurSeg.CurCluster.cbData));
 
         return writeSimpleBlockInternal(a_pTrack, tcBlock, pvData, cbData, VBOX_WEBM_BLOCK_FLAG_KEY_FRAME);
@@ -943 +943 @@
          * Write Cues element.
          */
-        LogFunc(("Cues @ %RU64\n", RTFileTell(m_Ebml.getFile())));
-
-        CurSeg.offCues = RTFileTell(m_Ebml.getFile());
-
-        m_Ebml.subStart(MkvElem_Cues);
-
-        std::list<WebMCueEntry>::iterator itCuePoint = CurSeg.lstCues.begin();
-        while (itCuePoint != CurSeg.lstCues.end())
-        {
-            m_Ebml.subStart(MkvElem_CuePoint)
-                  .serializeUnsignedInteger(MkvElem_CueTime, itCuePoint->time)
-                  .subStart(MkvElem_CueTrackPositions)
-                  .serializeUnsignedInteger(MkvElem_CueTrack, 1)
-                  .serializeUnsignedInteger(MkvElem_CueClusterPosition, itCuePoint->loc - CurSeg.offStart, 8)
-                  .subEnd(MkvElem_CueTrackPositions)
-                  .subEnd(MkvElem_CuePoint);
-
-            itCuePoint++;
-        }
-
-        m_Ebml.subEnd(MkvElem_Cues)
-              .subEnd(MkvElem_Segment);
+        if (CurSeg.lstCues.size())
+        {
+            LogFunc(("Cues @ %RU64\n", RTFileTell(m_Ebml.getFile())));
+
+            CurSeg.offCues = RTFileTell(m_Ebml.getFile());
+
+            m_Ebml.subStart(MkvElem_Cues);
+
+            std::list<WebMCueEntry>::iterator itCuePoint = CurSeg.lstCues.begin();
+            while (itCuePoint != CurSeg.lstCues.end())
+            {
+                LogFunc(("CuePoint @ %RU64\n", RTFileTell(m_Ebml.getFile())));
+
+                m_Ebml.subStart(MkvElem_CuePoint)
+                      .serializeUnsignedInteger(MkvElem_CueTime, itCuePoint->time)
+                      .subStart(MkvElem_CueTrackPositions)
+                      .serializeUnsignedInteger(MkvElem_CueTrack, 1)
+                      .serializeUnsignedInteger(MkvElem_CueClusterPosition, itCuePoint->loc - CurSeg.offStart, 8)
+                      .subEnd(MkvElem_CueTrackPositions)
+                      .subEnd(MkvElem_CuePoint);
+
+                itCuePoint++;
+            }
+
+            m_Ebml.subEnd(MkvElem_Cues);
+        }
+
+        m_Ebml.subEnd(MkvElem_Segment);
 
         /*
@@ -1010 +1016 @@
         LogFunc(("SeekHead @ %RU64\n", CurSeg.offSeekInfo));
 
-        m_Ebml.subStart(MkvElem_SeekHead)
-
-              .subStart(MkvElem_Seek)
+        m_Ebml.subStart(MkvElem_SeekHead);
+
+        m_Ebml.subStart(MkvElem_Seek)
               .serializeUnsignedInteger(MkvElem_SeekID, MkvElem_Tracks)
               .serializeUnsignedInteger(MkvElem_SeekPosition, CurSeg.offTracks - CurSeg.offStart, 8)
-              .subEnd(MkvElem_Seek)
-
-              .subStart(MkvElem_Seek)
-              .serializeUnsignedInteger(MkvElem_SeekID, MkvElem_Cues)
-              .serializeUnsignedInteger(MkvElem_SeekPosition, CurSeg.offCues - CurSeg.offStart, 8)
-              .subEnd(MkvElem_Seek)
-
-              .subStart(MkvElem_Seek)
+              .subEnd(MkvElem_Seek);
+
+        if (CurSeg.lstCues.size())
+        {
+            Assert(CurSeg.offCues - CurSeg.offStart > 0); /* Sanity. */
+
+            m_Ebml.subStart(MkvElem_Seek)
+                  .serializeUnsignedInteger(MkvElem_SeekID, MkvElem_Cues)
+                  .serializeUnsignedInteger(MkvElem_SeekPosition, CurSeg.offCues - CurSeg.offStart, 8)
+                  .subEnd(MkvElem_Seek);
+        }
+
+        m_Ebml.subStart(MkvElem_Seek)
               .serializeUnsignedInteger(MkvElem_SeekID, MkvElem_Info)
               .serializeUnsignedInteger(MkvElem_SeekPosition, CurSeg.offInfo - CurSeg.offStart, 8)
-              .subEnd(MkvElem_Seek)
-
-        .subEnd(MkvElem_SeekHead);
+              .subEnd(MkvElem_Seek);
+
+        m_Ebml.subEnd(MkvElem_SeekHead);
 
         //int64_t iFrameTime = (int64_t)1000 * 1 / 25; //m_Framerate.den / m_Framerate.num; /** @todo Fix this! */