Changeset 68677 in vbox for trunk

Timestamp:

Sep 6, 2017 11:14:16 AM (7 years ago)

Author:

vboxsync

Message:

Audio/DrvHostDSound.cpp: Always return success in dsoundControlStreamIn(), logging tweaks.

File:

• trunk/src/VBox/Devices/Audio/DrvHostDSound.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvHostDSound.cpp

@@ -1512 +1512 @@
         case PDMAUDIOSTREAMCMD_RESUME:
         {
-            DSLOG(("DSound: Playback PDMAUDIOSTREAMCMD_ENABLE\n"));
-            /* Try to start playback. If it fails, then reopen and try again. */
             hr = directSoundPlayStart(pThis, pStreamDS);
             if (FAILED(hr))
@@ -1544 +1542 @@
         case PDMAUDIOSTREAMCMD_PAUSE:
         {
-            DSLOG(("DSound: Playback PDMAUDIOSTREAMCMD_DISABLE\n"));
+            AssertPtr(pThis->pDS);
+
             hr = directSoundPlayStop(pThis, pStreamDS);
             if (FAILED(hr))
@@ -1778 +1777 @@
         case PDMAUDIOSTREAMCMD_PAUSE:
         {
-            hr = directSoundCaptureStop(pStreamDS);
-            if (FAILED(hr))
-                rc = VERR_NOT_SUPPORTED;
+            AssertPtr(pThis->pDSC);
+
+            directSoundCaptureStop(pStreamDS);
+
+            /* Return success in any case, as stopping the capture can fail if
+             * the capture buffer is not around anymore.
+             *
+             * This can happen if the host's capturing device has been changed suddenly. */
+            rc = VINF_SUCCESS;
             break;
         }