Changeset 68971 in vbox for trunk/src/VBox/Main

Timestamp:

Oct 4, 2017 9:56:06 AM (7 years ago)

Author:

vboxsync

Message:

VideoRec: Documentation, comments.

Location:

trunk/src/VBox/Main

Files:

• include/DisplayImpl.h (modified) (1 diff)
• src-client/ConsoleImpl.cpp (modified) (1 diff)
• src-client/DisplayImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/DisplayImpl.h

@@ -471 +471 @@
     void processDisplayData(void *pvVRAM, unsigned uScreenId);
 
-    /* Serializes access to mVideoAccelLegacy and mfVideoAccelVRDP, etc between VRDP and Display. */
-    RTCRITSECT mVideoAccelLock;
+    /** Serializes access to mVideoAccelLegacy and mfVideoAccelVRDP, etc between VRDP and Display. */
+    RTCRITSECT           mVideoAccelLock;
+
 #ifdef VBOX_WITH_VIDEOREC
     /* Serializes access to video capture source bitmaps. */
     RTCRITSECT           mVideoCaptureLock;
+    /** The current video recording configuration being used. */
     VIDEORECCFG          mVideoRecCfg;
+    /** The video recording context. */
     VIDEORECCONTEXT     *mpVideoRecCtx;
+    /** Array which defines which screens are being enabled for recording. */
     bool                 maVideoRecEnabled[SchemaDefs::MaxGuestMonitors];
 #endif

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -5511 +5511 @@
         {
             Display *pDisplay = mDisplay;
+            AssertPtr(pDisplay);
 
             /* Release lock because the call scheduled on EMT may also try to take it. */
             alock.release();
 
-            /*
-             * Call worker in EMT, that's faster and safer than doing everything
-             * using VM3ReqCall. Note that we separate VMR3ReqCall from VMR3ReqWait
-             * here to make requests from under the lock in order to serialize them.
-             */
             int vrc = VMR3ReqCallWaitU(ptrVM.rawUVM(), VMCPUID_ANY /*idDstCpu*/,
                                        (PFNRT)Display::i_videoCaptureConfigure, 3,

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -2498 +2498 @@
  * @returns IPRT status code.
  * @param   pThis               Display instance to configure video capturing for.
- * @param   pCfg                Video capturing configuration to use.
+ * @param   pCfg                Where to store the configuration into.
  * @param   fAttachDetach       Whether to attach/detach associated drivers or not.
  */