Changeset 69046 in vbox for trunk/src/VBox/Devices/Graphics

Timestamp:

Oct 11, 2017 4:11:23 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

118325

Message:

Global: replace fall-through comments with RT_FALL_THRU().
bugref:8192: gcc warnings

Location:

trunk/src/VBox/Devices/Graphics

Files:

• DevVGA-SVGA3d-info.cpp (modified) (2 diffs)
• DevVGA-SVGA3d-ogl.cpp (modified) (5 diffs)
• DevVGA-SVGA3d-savedstate.cpp (modified) (1 diff)
• DevVGA_VDMA.cpp (modified) (1 diff)
• shaderlib/glsl_shader.c (modified) (4 diffs)
• shaderlib/shader.c (modified) (3 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-info.cpp ¶

@@ -1036 +1036 @@
                     fHitFormatAssert = true;
                 }
-                /* fall thru */
+                RT_FALL_THRU();
             default:
                 /* Lazy programmer fallbacks. */
@@ -1270 +1270 @@
                     break;
                 default:
-                    AssertFailed();  /* Fall through */
+                    AssertFailed();  RT_FALL_THRU();
                 case 'b': //SVGA3dBlendOp
                 case 'e': //SVGA3dBlendEquation

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-ogl.cpp ¶

@@ -4202 +4202 @@
             if (pContext->state.aRenderState[SVGA3D_RS_BLENDENABLE].uintValue != 0)
                 continue;   /* ignore if blend is already enabled */
-        }  /* Fall through */
+        }  RT_FALL_THRU();
 
         case SVGA3D_RS_BLENDENABLE:            /* SVGA3dBool */
@@ -5796 +5796 @@
     case SVGA3D_DECLTYPE_UBYTE4N:
         normalized = GL_TRUE;
-        /* Fall through */
+        RT_FALL_THRU();
     case SVGA3D_DECLTYPE_UBYTE4:
         size = 4;
@@ -5804 +5804 @@
     case SVGA3D_DECLTYPE_SHORT2N:
         normalized = GL_TRUE;
-        /* Fall through */
+        RT_FALL_THRU();
     case SVGA3D_DECLTYPE_SHORT2:
         size = 2;
@@ -5812 +5812 @@
     case SVGA3D_DECLTYPE_SHORT4N:
         normalized = GL_TRUE;
-        /* Fall through */
+        RT_FALL_THRU();
     case SVGA3D_DECLTYPE_SHORT4:
         size = 4;
@@ -6207 +6207 @@
             case SVGA3D_DECLUSAGE_POSITIONT:
                 Log(("ShaderSetPositionTransformed: (%d,%d)\n", pContext->state.RectViewPort.w, pContext->state.RectViewPort.h));
-                /* Fall through */
+                RT_FALL_THRU();
             case SVGA3D_DECLUSAGE_POSITION:
                 ShaderSetPositionTransformed(pContext->pShaderContext, pContext->state.RectViewPort.w,

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-savedstate.cpp ¶

@@ -756 +756 @@
                         default:
                             AssertFailed();
-                            /* Fall through */
+                            RT_FALL_THRU();
                         case SVGA3D_SURFACE_HINT_DEPTHSTENCIL:
                         case SVGA3D_SURFACE_HINT_DEPTHSTENCIL | SVGA3D_SURFACE_HINT_TEXTURE:

trunk/src/VBox/Devices/Graphics/DevVGA_VDMA.cpp ¶

@@ -2661 +2661 @@
                     break;
             }
-            /* fall thru */
+            RT_FALL_THRU();
             case VBVAEXHOST_DATA_TYPE_NO_DATA:
                 rc = VBoxVDMAThreadEventWait(&pVdma->Thread, RT_INDEFINITE_WAIT);

trunk/src/VBox/Devices/Graphics/shaderlib/glsl_shader.c ¶

@@ -519 +519 @@
                     break;
                 }
-            }  /* Fall through */
+            }  RT_FALL_THRU();
 
             case HEAP_NODE_TRAVERSE_RIGHT:
@@ -535 +535 @@
                     break;
                 }
-            }  /* Fall through */
+            }  RT_FALL_THRU();
 
             case HEAP_NODE_POP:
@@ -595 +595 @@
                     break;
                 }
-            }  /* Fall through */
+            }  RT_FALL_THRU();
 
             case HEAP_NODE_TRAVERSE_RIGHT:
@@ -610 +610 @@
                     break;
                 }
-            }  /* Fall through */
+            }  RT_FALL_THRU();
 
             case HEAP_NODE_POP:

trunk/src/VBox/Devices/Graphics/shaderlib/shader.c ¶

@@ -1741 +1741 @@
         case WINED3D_SHADER_VERSION(4, 0):
             FIXME("Using 3.0 limits for 4.0 shader.\n");
-            /* Fall through. */
+            RT_FALL_THRU();
 
         case WINED3D_SHADER_VERSION(3, 0):
@@ -2110 +2110 @@
                     switch (stateblock->renderState[WINED3DRS_FOGVERTEXMODE])
                     {
-                        case WINED3DFOG_NONE: /* Fall through. */
+                        case WINED3DFOG_NONE: RT_FALL_THRU();
                         case WINED3DFOG_LINEAR: args->fog = FOG_LINEAR; break;
                         case WINED3DFOG_EXP:    args->fog = FOG_EXP;    break;
@@ -2189 +2189 @@
         case WINED3D_SHADER_VERSION(4, 0):
             FIXME("Using 3.0 limits for 4.0 shader.\n");
-            /* Fall through. */
+            RT_FALL_THRU();
 
         case WINED3D_SHADER_VERSION(3, 0):