Changeset 69046 in vbox for trunk/src/VBox/ValidationKit/utils/cpu

Timestamp:

Oct 11, 2017 4:11:23 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

118325

Message:

Global: replace fall-through comments with RT_FALL_THRU().
bugref:8192: gcc warnings

File:

• trunk/src/VBox/ValidationKit/utils/cpu/cidet-core.cpp (modified) (5 diffs)

trunk/src/VBox/ValidationKit/utils/cpu/cidet-core.cpp

@@ -1117 +1117 @@
                 if (pThis->fTestCfg & CIDET_TESTCFG_SEG_PRF_ES)
                     return true;
-                /* fall thru */
+                RT_FALL_THRU();
             case X86_SREG_ES:
                 pThis->uSegPrf = X86_SREG_CS;
                 if (pThis->fTestCfg & CIDET_TESTCFG_SEG_PRF_CS)
                     return true;
-                /* fall thru */
+                RT_FALL_THRU();
             case X86_SREG_CS:
                 pThis->uSegPrf = X86_SREG_SS;
                 if (pThis->fTestCfg & CIDET_TESTCFG_SEG_PRF_SS)
                     return true;
-                /* fall thru */
+                RT_FALL_THRU();
             case X86_SREG_SS:
                 pThis->uSegPrf = X86_SREG_DS;
                 if (pThis->fTestCfg & CIDET_TESTCFG_SEG_PRF_DS)
                     return true;
-                /* fall thru */
+                RT_FALL_THRU();
             case X86_SREG_DS:
                 pThis->uSegPrf = X86_SREG_FS;
                 if (pThis->fTestCfg & CIDET_TESTCFG_SEG_PRF_FS)
                     return true;
-                /* fall thru */
+                RT_FALL_THRU();
             case X86_SREG_FS:
                 pThis->uSegPrf = X86_SREG_GS;
                 if (pThis->fTestCfg & CIDET_TESTCFG_SEG_PRF_GS)
                     return true;
-                /* fall thru */
+                RT_FALL_THRU();
             case X86_SREG_GS:
                 break;
@@ -1919 +1919 @@
     switch (pThis->pCurInstr->cbOpcode)
     {
-        case 3: off++; /* fall thru */
-        case 2: off++; /* fall thru */
+        case 3: off++; RT_FALL_THRU();
+        case 2: off++; RT_FALL_THRU();
         case 1: off++;
             break;
@@ -2037 +2037 @@
     switch (pThis->pCurInstr->cbOpcode)
     {
-        case 3: pThis->abInstr[off++] = *pbOpcode++; /* fall thru */
-        case 2: pThis->abInstr[off++] = *pbOpcode++; /* fall thru */
+        case 3: pThis->abInstr[off++] = *pbOpcode++; RT_FALL_THRU();
+        case 2: pThis->abInstr[off++] = *pbOpcode++; RT_FALL_THRU();
         case 1: pThis->abInstr[off++] = *pbOpcode++;
             break;
@@ -2059 +2059 @@
             {
                 case 0: break;
-                case 8: pThis->abInstr[off + 3] = (uDispValue >> 56) & UINT8_C(0xff); /* fall thru */
-                case 7: pThis->abInstr[off + 3] = (uDispValue >> 48) & UINT8_C(0xff); /* fall thru */
-                case 6: pThis->abInstr[off + 3] = (uDispValue >> 40) & UINT8_C(0xff); /* fall thru */
-                case 5: pThis->abInstr[off + 3] = (uDispValue >> 32) & UINT8_C(0xff); /* fall thru */
-                case 4: pThis->abInstr[off + 3] = (uDispValue >> 24) & UINT8_C(0xff); /* fall thru */
-                case 3: pThis->abInstr[off + 2] = (uDispValue >> 16) & UINT8_C(0xff); /* fall thru */
-                case 2: pThis->abInstr[off + 1] = (uDispValue >>  8) & UINT8_C(0xff); /* fall thru */
+                case 8: pThis->abInstr[off + 3] = (uDispValue >> 56) & UINT8_C(0xff); RT_FALL_THRU();
+                case 7: pThis->abInstr[off + 3] = (uDispValue >> 48) & UINT8_C(0xff); RT_FALL_THRU();
+                case 6: pThis->abInstr[off + 3] = (uDispValue >> 40) & UINT8_C(0xff); RT_FALL_THRU();
+                case 5: pThis->abInstr[off + 3] = (uDispValue >> 32) & UINT8_C(0xff); RT_FALL_THRU();
+                case 4: pThis->abInstr[off + 3] = (uDispValue >> 24) & UINT8_C(0xff); RT_FALL_THRU();
+                case 3: pThis->abInstr[off + 2] = (uDispValue >> 16) & UINT8_C(0xff); RT_FALL_THRU();
+                case 2: pThis->abInstr[off + 1] = (uDispValue >>  8) & UINT8_C(0xff); RT_FALL_THRU();
                 case 1: pThis->abInstr[off] = uDispValue & UINT8_C(0xff);
                     break;
@@ -2084 +2084 @@
             switch (pThis->aOperands[iOp].cb)
             {
-                case 8: pThis->abInstr[off + 3] = (uImmValue >> 56) & UINT8_C(0xff); /* fall thru */
-                case 7: pThis->abInstr[off + 3] = (uImmValue >> 48) & UINT8_C(0xff); /* fall thru */
-                case 6: pThis->abInstr[off + 3] = (uImmValue >> 40) & UINT8_C(0xff); /* fall thru */
-                case 5: pThis->abInstr[off + 3] = (uImmValue >> 32) & UINT8_C(0xff); /* fall thru */
-                case 4: pThis->abInstr[off + 3] = (uImmValue >> 24) & UINT8_C(0xff); /* fall thru */
-                case 3: pThis->abInstr[off + 2] = (uImmValue >> 16) & UINT8_C(0xff); /* fall thru */
-                case 2: pThis->abInstr[off + 1] = (uImmValue >>  8) & UINT8_C(0xff); /* fall thru */
+                case 8: pThis->abInstr[off + 3] = (uImmValue >> 56) & UINT8_C(0xff); RT_FALL_THRU();
+                case 7: pThis->abInstr[off + 3] = (uImmValue >> 48) & UINT8_C(0xff); RT_FALL_THRU();
+                case 6: pThis->abInstr[off + 3] = (uImmValue >> 40) & UINT8_C(0xff); RT_FALL_THRU();
+                case 5: pThis->abInstr[off + 3] = (uImmValue >> 32) & UINT8_C(0xff); RT_FALL_THRU();
+                case 4: pThis->abInstr[off + 3] = (uImmValue >> 24) & UINT8_C(0xff); RT_FALL_THRU();
+                case 3: pThis->abInstr[off + 2] = (uImmValue >> 16) & UINT8_C(0xff); RT_FALL_THRU();
+                case 2: pThis->abInstr[off + 1] = (uImmValue >>  8) & UINT8_C(0xff); RT_FALL_THRU();
                 case 1: pThis->abInstr[off] = uImmValue & UINT8_C(0xff);
                     break;