Changeset 69304 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Oct 25, 2017 1:41:16 PM (7 years ago)

Author:

vboxsync

Message:

Devices/Storage: scm updates

Location:

trunk/src/VBox/Devices/Storage

Files:

• DevATA.cpp (modified) (2 diffs)
• DevBusLogic.cpp (modified) (1 diff)
• DrvHostBase.cpp (modified) (1 diff)
• DrvHostDVD.cpp (modified) (1 diff)
• DrvRamDisk.cpp (modified) (3 diffs)
• DrvVD.cpp (modified) (3 diffs)
• VSCSI/VSCSILunMmc.cpp (modified) (2 diffs)
• VSCSI/VSCSILunSsc.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -138 +138 @@
 
 /** @} */
+
 
 /*********************************************************************************************************************************
@@ -2487 +2488 @@
             }
             else
-                rc = VERR_NOT_FOUND; /** @todo: Return lead-in information. */
+                rc = VERR_NOT_FOUND; /** @todo Return lead-in information. */
             break;
         }

trunk/src/VBox/Devices/Storage/DevBusLogic.cpp

@@ -2350 +2350 @@
             if ((uVal == BUSLOGICCOMMAND_EXECUTE_MAILBOX_COMMAND) && (pBusLogic->uOperationCode == 0xff))
             {
-                ///@todo: Should fail if BL_STAT_INREQ is set
+                /// @todo Should fail if BL_STAT_INREQ is set
                 /* If there are no mailboxes configured, don't even try to do anything. */
                 if (pBusLogic->cMailbox)

trunk/src/VBox/Devices/Storage/DrvHostBase.cpp

@@ -349 +349 @@
 
     /* For now just return one region for all devices. */
-    /** @todo: Handle CD/DVD passthrough properly. */
+    /** @todo Handle CD/DVD passthrough properly. */
 
     LogFlowFunc(("returns %u\n", cRegions));

trunk/src/VBox/Devices/Storage/DrvHostDVD.cpp

@@ -56 +56 @@
 /** Pointer to the host DVD driver instance data. */
 typedef DRVHOSTDVD *PDRVHOSTDVD;
+
 
 /*********************************************************************************************************************************

trunk/src/VBox/Devices/Storage/DrvRamDisk.cpp

@@ -40 +40 @@
 #include "VBoxDD.h"
 #include "IOBufMgmt.h"
+
 
 /*********************************************************************************************************************************
@@ -504 +505 @@
 /* -=-=-=-=- IMedia -=-=-=-=- */
 
+
 /*********************************************************************************************************************************
 *   Media interface methods                                                                                                      *
@@ -721 +723 @@
 DECLINLINE(unsigned) drvramdiskMediaExIoReqIdHash(PDMMEDIAEXIOREQID uIoReqId)
 {
-    return uIoReqId % DRVVD_VDIOREQ_ALLOC_BINS; /** @todo: Find something better? */
+    return uIoReqId % DRVVD_VDIOREQ_ALLOC_BINS; /** @todo Find something better? */
 }
 

trunk/src/VBox/Devices/Storage/DrvVD.cpp

@@ -537 +537 @@
 }
 
+
 /*********************************************************************************************************************************
 *   Error reporting callback                                                                                                     *
@@ -3113 +3114 @@
     LogFlowFunc(("pThis=%#p pIoReq=%#p cb=%zu\n", pThis, pIoReq, cb));
 
-/** @todo: This does not work at all with encryption enabled because the encryption plugin
+/** @todo This does not work at all with encryption enabled because the encryption plugin
  *         encrypts the data in place trashing guest memory and causing data corruption later on!
  *
@@ -4517 +4518 @@
     PDMDrvHlpSTAMDeregister(pDrvIns, &pThis->StatReqsPerSec);
 }
+
 
 /*********************************************************************************************************************************

trunk/src/VBox/Devices/Storage/VSCSI/VSCSILunMmc.cpp

@@ -31 +31 @@
 
 #include "VSCSIInternal.h"
+
 
 /*********************************************************************************************************************************
@@ -937 +938 @@
             }
             else
-                rc = VERR_NOT_FOUND; /** @todo: Return lead-in information. */
+                rc = VERR_NOT_FOUND; /** @todo Return lead-in information. */
             break;
         }

trunk/src/VBox/Devices/Storage/VSCSI/VSCSILunSsc.cpp

@@ -16 +16 @@
  */
 
-/*******************************************************************************
-*   Header Files                                                               *
-*******************************************************************************/
+
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #define LOG_GROUP LOG_GROUP_VSCSI
 #include <VBox/log.h>
@@ -182 +183 @@
                 *pu8ReplyPos++ = 0x45;  /* Travan TR-4 density. */
                 *pu8ReplyPos++ = 0;     /* All blocks are the same. */
-                *pu8ReplyPos++ = 0;     //@todo: this calls for some macros!
+                *pu8ReplyPos++ = 0;     /// @todo this calls for some macros!
                 *pu8ReplyPos++ = 0;
                 *pu8ReplyPos++ = 0;     /* Reserved. */
@@ -196 +197 @@
         case SCSI_MODE_SELECT_6:
         {
-            /* @todo: implement!! */
+            /** @todo implement!! */
             rcReq = vscsiLunReqSenseOkSet(pVScsiLun, pVScsiReq);
             break;
@@ -256 +257 @@
         case SCSI_LOAD_UNLOAD:
         {
-            //@todo: should load/unload do anyhting? is verify even supported?
+            /// @todo should load/unload do anyhting? is verify even supported?
             rcReq = vscsiLunReqSenseOkSet(pVScsiLun, pVScsiReq);
             break;
@@ -305 +306 @@
         }
         case SCSI_REWIND:
-            //@todo: flush data + write EOD? immed bit? partitions?
+            /// @todo flush data + write EOD? immed bit? partitions?
             pVScsiLUNSSC->uCurPos = 0;
             rcReq = vscsiLunReqSenseOkSet(pVScsiLun, pVScsiReq);
             break;
         case SCSI_RESERVE_6:
-            //@todo: perform actual reservation
+            /// @todo perform actual reservation
             rcReq = vscsiLunReqSenseOkSet(pVScsiLun, pVScsiReq);
             break;
         case SCSI_RELEASE_6:
-            //@todo: perform actual release
+            /// @todo perform actual release
             rcReq = vscsiLunReqSenseOkSet(pVScsiLun, pVScsiReq);
             break;
@@ -323 +324 @@
             /* Report unrestricted block sizes (1-FFFFFFh). */
             memset(aReply, 0, sizeof(aReply));
-            //@todo: Helpers for big-endian 16-bit/24-bit/32-bit constants?
+            /// @todo Helpers for big-endian 16-bit/24-bit/32-bit constants?
             aReply[1] = aReply[2] = aReply[3] = 0xff;
             aReply[5] = 0x01;