Changeset 69331 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

Oct 26, 2017 9:59:30 AM (7 years ago)

Author:

vboxsync

Message:

bugref:8674. Progress updates percent of execution only if new value differs from old value.

File:

• trunk/src/VBox/Main/src-all/ProgressImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-all/ProgressImpl.cpp

@@ -564 +564 @@
         {
             if (uPercentage > pThis->m_ulOperationPercent)
-                pThis->m_ulOperationPercent = RT_MIN(uPercentage, 100);
+                pThis->setCurrentOperationProgress(uPercentage);
         }
         else
@@ -571 +571 @@
             vrc = VERR_CANCELLED;
         }
-        ULONG actualPercent = 0;
-        pThis->getPercent(&actualPercent);
-        fireProgressPercentageChangedEvent(pThis->pEventSource, pThis->mId.toUtf16().raw(), actualPercent);
     }
     /* else ignored */
@@ -822 +819 @@
     AssertReturn(!mCompleted && !mCanceled, E_FAIL);
 
-    m_ulOperationPercent = aPercent;
-
-    ULONG actualPercent = 0;
-    getPercent(&actualPercent);
-    fireProgressPercentageChangedEvent(pEventSource, mId.toUtf16().raw(), actualPercent);
+    if (m_ulOperationPercent != aPercent)
+    {
+        m_ulOperationPercent = aPercent;
+        ULONG actualPercent = 0;
+        getPercent(&actualPercent);
+        fireProgressPercentageChangedEvent(pEventSource, mId.toUtf16().raw(), actualPercent);
+    }
 
     return S_OK;