Changeset 69392 in vbox for trunk

Timestamp:

Oct 26, 2017 5:24:52 PM (7 years ago)

Author:

vboxsync

Message:

GuestHost/OpenGL: scm updates

Location:

trunk

Files:

• .scm-settings (modified) (1 diff)
• src/VBox/GuestHost/OpenGL/.scm-settings (added)
• src/VBox/GuestHost/OpenGL/error/error.def (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/error/error.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/error/errorspu_init.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/glapi_parser/apiutil.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/opcodes.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_arrays.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_beginend.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_bounds.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_buffer.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_bufferobject.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_client.c (modified) (2 diffs, 1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_clipplane.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_context.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_current.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_currentheader.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_currenttypes.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_error.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_extensions.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_feedback.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_fence.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_fog.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_framebuffer.c (modified) (4 diffs)
• src/VBox/GuestHost/OpenGL/packer/pack_header.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_init.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_lights.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_lists.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_map.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_materials.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_matrices.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_misc.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_pica.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_pixelmap.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_pixels.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_point.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_program.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_regcombiner.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_shaders.c (modified) (5 diffs, 1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_stipple.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_swap.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_swap_lists.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_swap_map.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_swap_pixelmap.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_swap_texture.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_texture.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/pack_visibleregion.c (modified) (2 props)
• src/VBox/GuestHost/OpenGL/packer/packer.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/packer_bbox.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/packer/packer_defs.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/choosevisual.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/dispatch.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/dispatchheader.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/glloader.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/loader.def (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/spuchange.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/spucopy.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/spuinit.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/spu_loader/spuload.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/convert.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/gendiffcode.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/get_components.py (modified) (1 diff, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_attrib.c (modified) (1 diff, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_buffer.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_bufferobject.c (modified) (2 diffs, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_client.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_current.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_current.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_defs.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_diff.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_enable.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_error.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_evaluators.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_feedback.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_fence.c (modified) (1 diff, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_flush.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_fog.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_framebuffer.c (modified) (6 diffs)
• src/VBox/GuestHost/OpenGL/state_tracker/state_funcs.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_get.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_getstring.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_glsl.c (modified) (10 diffs)
• src/VBox/GuestHost/OpenGL/state_tracker/state_hint.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_init.c (modified) (1 diff, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_isenabled.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_lighting.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_limits.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_line.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_lists.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_multisample.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_occlude.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_pixel.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_point.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_polygon.c (modified) (1 diff, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_program.c (modified) (1 diff, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_rasterpos.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_regcombiner.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_snapshot.c (modified) (17 diffs, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_stencil.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_texdiff.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_teximage.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_texture.c (modified) (2 diffs, 1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_transform.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/state_tracker/state_viewport.c (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/util/blitter.cpp (modified) (4 diffs)
• src/VBox/GuestHost/OpenGL/util/compositor.cpp (modified) (2 diffs)
• src/VBox/GuestHost/OpenGL/util/debug_opcodes.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/util/lowercase.py (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/util/net.c (modified) (1 diff)
• src/VBox/GuestHost/OpenGL/util/pixel.c (modified) (1 diff)
• src/VBox/GuestHost/OpenGL/util/util.def (modified) (1 prop)
• src/VBox/GuestHost/OpenGL/util/vboxhgcm.c (modified) (8 diffs)
• src/VBox/GuestHost/OpenGL/util/vboxhgsmi.c (modified) (9 diffs)
• src/VBox/GuestHost/OpenGL/util/vreg.cpp (modified) (4 diffs)

trunk/.scm-settings

@@ -54 +54 @@
 --filter-out-dirs  "/src/apps/kchmviewer*/."
 
---filter-out-dirs  "/src/VBox/GuestHost/OpenGL/*/."
 --filter-out-dirs  "/src/VBox/Devices/Graphics/shaderlib*/."
 --filter-out-dirs  "/src/VBox/Devices/Graphics/vmsvga/."

trunk/src/VBox/GuestHost/OpenGL/packer/pack_client.c

@@ -673 +673 @@
     if (elementsBuffer && elementsBuffer->id)
     {
-        /*@todo not sure it's possible, and not sure what to do*/
+        /** @todo not sure it's possible, and not sure what to do*/
         if (!elementsBuffer->data)
         {
@@ -720 +720 @@
     if (elementsBuffer && elementsBuffer->id)
     {
-        /*@todo not sure it's possible, and not sure what to do*/
+        /** @todo not sure it's possible, and not sure what to do*/
         if (!elementsBuffer->data)
         {

trunk/src/VBox/GuestHost/OpenGL/packer/pack_framebuffer.c

@@ -21 +21 @@
 #include "cr_string.h"
 
-void PACK_APIENTRY 
+void PACK_APIENTRY
 crPackDeleteRenderbuffersEXT(GLsizei n, const GLuint * renderbuffers)
 {
@@ -38 +38 @@
 }
 
-void PACK_APIENTRY 
+void PACK_APIENTRY
 crPackDeleteFramebuffersEXT(GLsizei n, const GLuint * framebuffers)
 {
@@ -55 +55 @@
 }
 
-void PACK_APIENTRY 
+void PACK_APIENTRY
 crPackDeleteRenderbuffersEXTSWAP(GLsizei n, const GLuint * renderbuffers)
 {
@@ -63 +63 @@
 }
 
-void PACK_APIENTRY 
+void PACK_APIENTRY
 crPackDeleteFramebuffersEXTSWAP(GLsizei n, const GLuint * framebuffers)
 {

trunk/src/VBox/GuestHost/OpenGL/packer/pack_shaders.c

@@ -56 +56 @@
         packet_length += pLocalLength[i];
     }
-    
+
     if (length)
     {
@@ -408 +408 @@
 }
 
-/*@todo next 8 functions are bit hacky, 
+/** @todo next 8 functions are bit hacky,
  * we expect packspu to pass a single structure with all output parameters via first output pointer.
  * it'd be better to add CRMessageMultiReadback one day.
@@ -474 +474 @@
 void PACK_APIENTRY crPackGetAttachedObjectsARB(VBoxGLhandleARB containerObj, GLsizei maxCount, GLsizei * count, VBoxGLhandleARB * obj, int * writeback)
 {
-        CR_GET_PACKER_CONTEXT(pc);
-        unsigned char *data_ptr;
-        (void) pc; (void) obj;
-        CR_GET_BUFFERED_POINTER(pc, 32);
-        WRITE_DATA(0, GLint, 32);
-        WRITE_DATA(4, GLenum, CR_GETATTACHEDOBJECTSARB_EXTEND_OPCODE);
-        WRITE_DATA(8, VBoxGLhandleARB, containerObj);
-        WRITE_DATA(12, GLsizei, maxCount);
-        WRITE_NETWORK_POINTER(16, (void *) count);
-        WRITE_NETWORK_POINTER(24, (void *) writeback);
-        WRITE_OPCODE(pc, CR_EXTEND_OPCODE);
-        CR_CMDBLOCK_CHECK_FLUSH(pc);
+        CR_GET_PACKER_CONTEXT(pc);
+        unsigned char *data_ptr;
+        (void) pc; (void) obj;
+        CR_GET_BUFFERED_POINTER(pc, 32);
+        WRITE_DATA(0, GLint, 32);
+        WRITE_DATA(4, GLenum, CR_GETATTACHEDOBJECTSARB_EXTEND_OPCODE);
+        WRITE_DATA(8, VBoxGLhandleARB, containerObj);
+        WRITE_DATA(12, GLsizei, maxCount);
+        WRITE_NETWORK_POINTER(16, (void *) count);
+        WRITE_NETWORK_POINTER(24, (void *) writeback);
+        WRITE_OPCODE(pc, CR_EXTEND_OPCODE);
+        CR_CMDBLOCK_CHECK_FLUSH(pc);
     CR_UNLOCK_PACKER_CONTEXT(pc);
 }
@@ -491 +491 @@
 void PACK_APIENTRY crPackGetInfoLogARB(VBoxGLhandleARB obj, GLsizei maxLength, GLsizei * length, GLcharARB * infoLog, int * writeback)
 {
-        CR_GET_PACKER_CONTEXT(pc);
-        unsigned char *data_ptr;
-        (void) pc; (void) infoLog;
-        CR_GET_BUFFERED_POINTER(pc, 32);
-        WRITE_DATA(0, GLint, 32);
-        WRITE_DATA(4, GLenum, CR_GETINFOLOGARB_EXTEND_OPCODE);
-        WRITE_DATA(8, VBoxGLhandleARB, obj);
-        WRITE_DATA(12, GLsizei, maxLength);
-        WRITE_NETWORK_POINTER(16, (void *) length);
-        WRITE_NETWORK_POINTER(24, (void *) writeback);
-        WRITE_OPCODE(pc, CR_EXTEND_OPCODE);
-        CR_CMDBLOCK_CHECK_FLUSH(pc);
+        CR_GET_PACKER_CONTEXT(pc);
+        unsigned char *data_ptr;
+        (void) pc; (void) infoLog;
+        CR_GET_BUFFERED_POINTER(pc, 32);
+        WRITE_DATA(0, GLint, 32);
+        WRITE_DATA(4, GLenum, CR_GETINFOLOGARB_EXTEND_OPCODE);
+        WRITE_DATA(8, VBoxGLhandleARB, obj);
+        WRITE_DATA(12, GLsizei, maxLength);
+        WRITE_NETWORK_POINTER(16, (void *) length);
+        WRITE_NETWORK_POINTER(24, (void *) writeback);
+        WRITE_OPCODE(pc, CR_EXTEND_OPCODE);
+        CR_CMDBLOCK_CHECK_FLUSH(pc);
     CR_UNLOCK_PACKER_CONTEXT(pc);
 }
@@ -562 +562 @@
 void PACK_APIENTRY crPackGetUniformsLocations(GLuint program, GLsizei maxcbData, GLsizei * cbData, GLvoid * pData, int * writeback)
 {
-        CR_GET_PACKER_CONTEXT(pc);
+        CR_GET_PACKER_CONTEXT(pc);
     unsigned char *data_ptr;
     (void) pData;

trunk/src/VBox/GuestHost/OpenGL/state_tracker/get_components.py

@@ -140 +140 @@
 """)
 
-

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_attrib.c

@@ -56 +56 @@
 }
 
-/*@todo check if NV rect needed too*/
+/** @todo check if NV rect needed too*/
 static void
 copy_texunit(CRTextureUnit *dest, const CRTextureUnit *src)

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_bufferobject.c

@@ -997 +997 @@
     if (pBufferObj->data)
     {
-        /*@todo http://www.opengl.org/registry/specs/ARB/pixel_buffer_object.txt
+        /** @todo http://www.opengl.org/registry/specs/ARB/pixel_buffer_object.txt
           "While it is entirely legal to create a buffer object by binding
           it to GL_ARRAY_BUFFER and loading it with data, then using it
@@ -1125 +1125 @@
 }
 
-

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_fence.c

@@ -49 +49 @@
 }
 
-

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_framebuffer.c

@@ -175 +175 @@
     int u;
 
-    if (!pFBO) 
+    if (!pFBO)
         return;
 
@@ -394 +394 @@
     }
 
-    /* @todo: http://www.opengl.org/registry/specs/ARB/framebuffer_object.txt 
+    /** @todo http://www.opengl.org/registry/specs/ARB/framebuffer_object.txt
      * FBO status might change when binding a different FBO here...but I doubt it happens.
      * So no status reset here until a proper check.
@@ -479 +479 @@
 }
 
-/*@todo: move this function somewhere else*/
+/** @todo move this function somewhere else*/
 /*return floor of base 2 log of x. log(0)==0*/
 static unsigned int crLog2Floor(unsigned int x)
@@ -874 +874 @@
 {
     (void)target;
-    /*@todo*/
+    /** @todo */
 }
 
@@ -900 +900 @@
         case GL_TEXTURE:
             CRASSERT(pAP->name!=0);
-            
+
             tobj = (CRTextureObj *) crHashtableSearch(ctx->shared->textureTable, pAP->name);
             if (tobj)
@@ -987 +987 @@
         diff_api.BindRenderbufferEXT(GL_RENDERBUFFER_EXT, to->framebufferobject.renderbuffer?
             to->framebufferobject.renderbuffer->hwid:0);
-    } 
-    else 
+    }
+    else
     {
         if (to->framebufferobject.drawFB!=from->framebufferobject.drawFB

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_glsl.c

@@ -139 +139 @@
 
     pRealShader = crStateGetShaderObj(pShader->id);
-    
+
     if (pRealShader)
     {
@@ -188 +188 @@
     CRContext *g = GetCurrentContext();
 
-    /*@todo: hack to allow crStateFreeGLSLProgram to work correctly, 
+    /** @todo hack to allow crStateFreeGLSLProgram to work correctly,
       as the current context isn't the one being destroyed*/
 #ifdef CHROMIUM_THREADSAFE
@@ -671 +671 @@
     pAttribs[pProgram->currentState.cAttribs].index = index;
     pAttribs[pProgram->currentState.cAttribs].name = crStrdup(name);
-    
+
     pProgram->currentState.cAttribs++;
     if (pProgram->currentState.pAttribs) crFree(pProgram->currentState.pAttribs);
@@ -827 +827 @@
 }
 
-/*@todo: one of those functions should ignore uniforms starting with "gl"*/
+/** @todo one of those functions should ignore uniforms starting with "gl"*/
 
 #ifdef IN_GUEST
-DECLEXPORT(void) STATE_APIENTRY 
+DECLEXPORT(void) STATE_APIENTRY
 crStateGLSLProgramCacheUniforms(GLuint program, GLsizei cbData, GLvoid *pData)
 {
@@ -981 +981 @@
 }
 #else /* IN_GUEST */
-static GLboolean crStateGLSLProgramCacheOneUniform(GLuint location, GLsizei cbName, GLchar *pName, 
+static GLboolean crStateGLSLProgramCacheOneUniform(GLuint location, GLsizei cbName, GLchar *pName,
                                                    char **pCurrent, GLsizei *pcbWritten, GLsizei maxcbData)
 {
@@ -1004 +1004 @@
 }
 
-DECLEXPORT(void) STATE_APIENTRY 
+DECLEXPORT(void) STATE_APIENTRY
 crStateGLSLProgramCacheUniforms(GLuint program, GLsizei maxcbData, GLsizei *cbData, GLvoid *pData)
 {
@@ -1021 +1021 @@
      * OpenGL spec says about GL_ACTIVE_UNIFORM_MAX_LENGTH:
      * "If no active uniform variable exist, 0 is returned."
-     */ 
+     */
     diff_api.GetProgramiv(pProgram->hwid, GL_ACTIVE_UNIFORM_MAX_LENGTH, &maxUniformLen);
     if (maxUniformLen > 0)
@@ -1077 +1077 @@
                  *The name returned by glGetActiveUniform is driver dependent,
                  *atleast it's with [0] on win/ati and without [0] on linux/nvidia.
-                 */                
+                 */
                 if (!pIndexStr)
                 {
@@ -1364 +1364 @@
     CRGLSLProgram *pProgram = (CRGLSLProgram *) data2;
     (void) key;
-    
+
     if (pShader->source)
     {
@@ -1380 +1380 @@
     CRGLSLProgram *pProgram = (CRGLSLProgram *) data2;
     (void) key;
-    
+
     diff_api.DetachShader(pProgram->hwid, pShader->hwid);
 }

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_init.c

@@ -436 +436 @@
 }
 
-/*@todo crStateAttribDestroy*/
+/** @todo crStateAttribDestroy*/
 static void
 crStateFreeContext(CRContext *ctx)

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_polygon.c

@@ -186 +186 @@
     }
 
-    /*@todo track mask if buffer is bound?*/
+    /** @todo track mask if buffer is bound?*/
     if (!crStateIsBufferBound(GL_PIXEL_UNPACK_BUFFER_ARB))
     {

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_program.c

@@ -2306 +2306 @@
 }
 
-/*@todo support NVprograms and add some data validity checks*/
+/** @todo support NVprograms and add some data validity checks*/
 static void
 DiffProgramCallback(unsigned long key, void *pProg, void *pCtx)

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_snapshot.c

@@ -38 +38 @@
  * we'd have to update this code if we'd change state tracking.
  * On the bright side it's fast, though it's not really needed as it's not that often operation.
- * It could also worth to split those functions into appropriate parts, 
+ * It could also worth to split those functions into appropriate parts,
  * similar to the way context creation is being done.
  *
  * Second way would be to implement full dispatch api table and substitute diff_api during saving/loading.
- * Then if we implement that api in a similar way to packer/unpacker with a change to store/load 
+ * Then if we implement that api in a similar way to packer/unpacker with a change to store/load
  * via provided pSSM handle instead of pack buffer,
  * saving state could be done by simple diffing against empty "dummy" context.
@@ -400 +400 @@
     int32_t rc, face, i;
     GLint bound = 0;
-    
+
     CRASSERT(pTexture && pSSM);
 
@@ -419 +419 @@
             }
 #ifdef CR_STATE_NO_TEXTURE_IMAGE_STORE
-            /* Note, this is not a bug. 
+            /* Note, this is not a bug.
              * Even with CR_STATE_NO_TEXTURE_IMAGE_STORE defined, it's possible that ptl->img!=NULL.
              * For ex. we're saving snapshot right after it was loaded
@@ -515 +515 @@
 #endif
 
-                    /*@todo: ugly workaround for crashes inside ati driver,
+                    /** @todo ugly workaround for crashes inside ati driver,
                      *       they overwrite their own allocated memory in cases where texlevel >=4
                              and width or height <=2.
@@ -559 +559 @@
 {
     int32_t rc, face, i;
-    
+
     CRASSERT(pTexture && pSSM);
 
@@ -623 +623 @@
 {
     int32_t rc;
-    
+
     CRASSERT(pStack && pSSM);
 
@@ -1221 +1221 @@
 
                 crStateSaveString(name, pSSM);
-            
+
                 if (crStateIsIntUniform(type))
                 {
@@ -1597 +1597 @@
 
     /* Save attrib stack*/
-    /*@todo could go up to used stack depth here?*/
+    /** @todo could go up to used stack depth here?*/
     for ( i = 0 ; i < CR_MAX_ATTRIB_STACK_DEPTH ; i++)
     {
@@ -2112 +2112 @@
 #endif /*CR_ARB_vertex_buffer_object*/
 
-    /*@todo CR_NV_vertex_program*/
+    /** @todo CR_NV_vertex_program*/
     crStateCopyEvalPtrs1D(pTmpContext->eval.eval1D, pContext->eval.eval1D);
     crStateCopyEvalPtrs2D(pTmpContext->eval.eval2D, pContext->eval.eval2D);
-    
-    SLC_COPYPTR(feedback.buffer);  /*@todo*/
-    SLC_COPYPTR(selection.buffer); /*@todo*/
+
+    SLC_COPYPTR(feedback.buffer);  /** @todo */
+    SLC_COPYPTR(selection.buffer); /** @todo */
 
     SLC_COPYPTR(lighting.light);
@@ -2125 +2125 @@
 
 #if CR_ARB_occlusion_query
-    SLC_COPYPTR(occlusion.objects); /*@todo*/
+    SLC_COPYPTR(occlusion.objects); /** @todo */
 #endif
 
@@ -2387 +2387 @@
             rc = SSMR3GetMem(pSSM, pBufferObj->data, pBufferObj->size);
             AssertRCReturn(rc, rc);
-        } 
+        }
         else if (pBufferObj->id!=0 && pBufferObj->size>0)
         {
@@ -2403 +2403 @@
 
         if (key!=0)
-            crHashtableAdd(pContext->shared->buffersTable, key, pBufferObj);        
+            crHashtableAdd(pContext->shared->buffersTable, key, pBufferObj);
     }
     /* Load pointers */
@@ -2458 +2458 @@
         crHashtableAdd(pContext->program.programHash, pProgram->id, pProgram);
         //DIRTY(pProgram->dirtyProgram, pContext->neg_bitid);
-        
+
     }
     /* Load Pointers */
@@ -2528 +2528 @@
     rc = SSMR3GetU32(pSSM, &ui);
     AssertRCReturn(rc, rc);
-    pContext->framebufferobject.drawFB = ui==0 ? NULL 
+    pContext->framebufferobject.drawFB = ui==0 ? NULL
                                                : crHashtableSearch(pContext->shared->fbTable, ui);
 
     rc = SSMR3GetU32(pSSM, &ui);
     AssertRCReturn(rc, rc);
-    pContext->framebufferobject.readFB = ui==0 ? NULL 
+    pContext->framebufferobject.readFB = ui==0 ? NULL
                                                : crHashtableSearch(pContext->shared->fbTable, ui);
 
     rc = SSMR3GetU32(pSSM, &ui);
     AssertRCReturn(rc, rc);
-    pContext->framebufferobject.renderbuffer = ui==0 ? NULL 
+    pContext->framebufferobject.renderbuffer = ui==0 ? NULL
                                                      : crHashtableSearch(pContext->shared->rbTable, ui);
 
@@ -2591 +2591 @@
         }
 
-        if (pProgram->activeState.attachedShaders)  
+        if (pProgram->activeState.attachedShaders)
         {
             pProgram->activeState.attachedShaders = crAllocHashtable();
@@ -2606 +2606 @@
         }
 
-        if (pProgram->currentState.cAttribs) 
+        if (pProgram->currentState.cAttribs)
             pProgram->currentState.pAttribs = (CRGLSLAttrib*) crAlloc(pProgram->currentState.cAttribs*sizeof(CRGLSLAttrib));
         for (k=0; k<pProgram->currentState.cAttribs; ++k)
@@ -2615 +2615 @@
         }
 
-        if (pProgram->activeState.cAttribs) 
+        if (pProgram->activeState.cAttribs)
             pProgram->activeState.pAttribs = (CRGLSLAttrib*) crAlloc(pProgram->activeState.cAttribs*sizeof(CRGLSLAttrib));
         for (k=0; k<pProgram->activeState.cAttribs; ++k)

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_texture.c

@@ -3321 +3321 @@
          * the crserverlib code be able to pass it to host ogl */
 
-        /* TODO: store texture priorities in the state data to be able to restore it properly
+        /** @todo store texture priorities in the state data to be able to restore it properly
          * on save state load */
     }
@@ -3336 +3336 @@
     UNUSED(textures);
     UNUSED(residences);
-    /* TODO: */
+    /** @todo */
     return GL_TRUE;
 }

trunk/src/VBox/GuestHost/OpenGL/util/blitter.cpp

@@ -17 +17 @@
 
 
-/*******************************************************************************
-*   Header Files                                                               *
-*******************************************************************************/
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #ifdef IN_VMSVGA3D
 # include <OpenGL/OpenGL.h>
@@ -833 +833 @@
         crWarning("GL_ARB_pixel_buffer_object not supported");
 
-    /* BlitFramebuffer seems to be buggy on Intel, 
+    /* BlitFramebuffer seems to be buggy on Intel,
      * try always glDrawXxx for now */
     if (!pBlitter->Flags.ForceDrawBlit && crStrstr(pszExtension, "GL_EXT_framebuffer_blit"))
@@ -1001 +1001 @@
     pBlitter->pDispatch->BindFramebufferEXT(GL_DRAW_FRAMEBUFFER, pBlitter->idFBO);
 
-    /* TODO: mag/min filters ? */
+    /** @todo mag/min filters ? */
 
     pBlitter->pDispatch->FramebufferTexture2DEXT(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, pDst->target, pDst->hwid, 0);
@@ -1161 +1161 @@
     crWarning("GLSL unsuported, gl version %d", pCache->iGlVersion);
 
-    /* @todo: we could also check for GL_ARB_shader_objects and GL_ARB_fragment_shader,
+    /** @todo we could also check for GL_ARB_shader_objects and GL_ARB_fragment_shader,
      * but seems like chromium does not support properly gl*Object versions of shader functions used with those extensions */
     return false;

trunk/src/VBox/GuestHost/OpenGL/util/compositor.cpp

@@ -16 +16 @@
  */
 
-/*******************************************************************************
-*   Header Files                                                               *
-*******************************************************************************/
+
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #include "../include/cr_compositor.h"
 
 
-/*******************************************************************************
-*   Defined Constants And Macros                                               *
-*******************************************************************************/
+/*********************************************************************************************************************************
+*   Defined Constants And Macros                                                                                                 *
+*********************************************************************************************************************************/
 #define VBOXVR_SCR_COMPOSITOR_RECTS_UNDEFINED UINT32_MAX
 #ifdef IN_VMSVGA3D
@@ -514 +515 @@
                                                    bool fPosRelated, bool *pfChanged)
 {
-    /* @todo: the fChanged sate calculation is really rough now, this is enough for now though */
+    /** @todo the fChanged sate calculation is really rough now, this is enough for now though */
     bool fChanged = false, fPosChanged = false;
     bool fWasInList = CrVrScrCompositorEntryIsInList(pEntry);

trunk/src/VBox/GuestHost/OpenGL/util/net.c

@@ -441 +441 @@
     {
 #ifdef WINDOWS
-        /* @todo: do we actually need that WSA stuff with VBox at all? */
+        /** @todo do we actually need that WSA stuff with VBox at all? */
         WORD wVersionRequested = MAKEWORD(2, 0);
         WSADATA wsaData;

trunk/src/VBox/GuestHost/OpenGL/util/pixel.c

@@ -1693 +1693 @@
     (void)dstPacking;
 
-    /*@todo this should be implemented properly*/
+    /** @todo this should be implemented properly*/
 
 #ifndef DEBUG_misha

trunk/src/VBox/GuestHost/OpenGL/util/vboxhgcm.c

@@ -46 +46 @@
 #endif
 
-/*@todo move define somewhere else, and make sure it's less than VBGLR0_MAX_HGCM_KERNEL_PARM*/
+/** @todo move define somewhere else, and make sure it's less than VBGLR0_MAX_HGCM_KERNEL_PARM*/
 /*If we fail to pass data in one chunk, send it in chunks of this size instead*/
 #define CR_HGCM_SPLIT_BUFFER_SIZE (8*_1M)
@@ -545 +545 @@
 
 #ifndef IN_GUEST
-/*@todo get rid of it*/
+/** @todo get rid of it*/
 static bool _crVBoxHGCMWriteBytes(CRConnection *conn, const void *buf, uint32_t len)
 {
@@ -593 +593 @@
     else
 # endif
-    {        
+    {
         rc = VbglR3HGCMCall(pData, cbData);
         if (RT_SUCCESS(rc))
@@ -916 +916 @@
     {
 #ifndef IN_GUEST
-            /**@todo remove temp buffer allocation in unpacker*/
+            /** @todo remove temp buffer allocation in unpacker*/
             /* we're at the host side, so just store data until guest polls us */
             _crVBoxHGCMWriteBytes(conn, start, len);
@@ -1023 +1023 @@
     CRASSERT(hgcm_buffer->magic == CR_VBOXHGCM_BUFFER_MAGIC);
 
-    /*@todo wrong len for redir buffers*/
+    /** @todo wrong len for redir buffers*/
     conn->recv_credits += hgcm_buffer->len;
 
@@ -1033 +1033 @@
 #endif
             if (g_crvboxhgcm.bufpool) {
-                /**@todo o'rly? */
+                /** @todo o'rly? */
                 /* pool may have been deallocated just a bit earlier in response
                  * to a SIGPIPE (Broken Pipe) signal.
@@ -1376 +1376 @@
 }
 
-/*@todo same, replace DeviceIoControl with vbglR3DoIOCtl */
+/** @todo same, replace DeviceIoControl with vbglR3DoIOCtl */
 static void crVBoxHGCMDoDisconnect( CRConnection *conn )
 {
@@ -2189 +2189 @@
 
     /* Can't open VBox guest driver here, because it gets called for host side as well */
-    /*@todo as we have 2 dll versions, can do it now.*/
+    /** @todo as we have 2 dll versions, can do it now.*/
 
 #ifdef RT_OS_WINDOWS

trunk/src/VBox/GuestHost/OpenGL/util/vboxhgsmi.c

@@ -618 +618 @@
         {
             _crVBoxHGSMIWaitCmd(pClient);
-                /* @todo: do we need to wait for completion actually?
+                /** @todo do we need to wait for completion actually?
                  * NOTE: in case we do not need completion,
                  * we MUST specify bDoNotSignalCompletion flag for the command buffer */
@@ -652 +652 @@
         {
             _crVBoxHGSMIWaitCmd(pClient);
-                /* @todo: do we need to wait for completion actually?
+                /** @todo do we need to wait for completion actually?
                  * NOTE: in case we do not need completion,
                  * we MUST specify bDoNotSignalCompletion flag for the command buffer */
@@ -924 +924 @@
         pClient = _crVBoxHGSMIClientGet();
 #ifndef IN_GUEST
-            //@todo remove temp buffer allocation in unpacker
+            /// @todo remove temp buffer allocation in unpacker
             /* we're at the host side, so just store data until guest polls us */
             _crVBoxHGCMWriteBytes(conn, start, len);
@@ -1010 +1010 @@
     else
     {
-        /*@todo wrong len for redir buffers*/
+        /** @todo wrong len for redir buffers*/
         conn->recv_credits += hgsmi_buffer->u32Len;
 
@@ -1245 +1245 @@
 }
 
-/*@todo same, replace DeviceIoControl with vbglR3DoIOCtl */
+/** @todo same, replace DeviceIoControl with vbglR3DoIOCtl */
 static void crVBoxHGSMIDoDisconnect( CRConnection *conn )
 {
@@ -1261 +1261 @@
     conn->cbBuffer = 0;
 
-    //@todo hold lock here?
+    /// @todo hold lock here?
     if (conn->type == CR_VBOXHGCM)
     {
@@ -1348 +1348 @@
     Assert(0);
 
-    /* @todo */
+    /** @todo */
 }
 
@@ -1395 +1395 @@
 
     /* Can't open VBox guest driver here, because it gets called for host side as well */
-    /*@todo as we have 2 dll versions, can do it now.*/
+    /** @todo as we have 2 dll versions, can do it now.*/
 
 #ifdef RT_OS_WINDOWS
@@ -1483 +1483 @@
     conn->allow_redir_ptr = 1;
 
-    //@todo remove this crap at all later
+    /// @todo remove this crap at all later
     conn->cbHostBufferAllocated = 0;//2*1024;
     conn->pHostBuffer = NULL;//(uint8_t*) crAlloc(conn->cbHostBufferAllocated);

trunk/src/VBox/GuestHost/OpenGL/util/vreg.cpp

@@ -16 +16 @@
  */
 
-/*******************************************************************************
-*   Header Files                                                               *
-*******************************************************************************/
+
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #ifdef IN_VMSVGA3D
 # include "../include/cr_vreg.h"
@@ -99 +100 @@
 
 
-/*******************************************************************************
-*   Defined Constants And Macros                                               *
-*******************************************************************************/
+/*********************************************************************************************************************************
+*   Defined Constants And Macros                                                                                                 *
+*********************************************************************************************************************************/
 #define VBOXVR_INVALID_COORD    (~0U)
 
 
-/*******************************************************************************
-*   Global Variables                                                           *
-*******************************************************************************/
+/*********************************************************************************************************************************
+*   Global Variables                                                                                                             *
+*********************************************************************************************************************************/
 static volatile int32_t g_cVBoxVrInits = 0;
 
@@ -812 +813 @@
                     Assert(VBoxRectCmp(pRect2, &RegRect1));
 
-                    /* @todo: this can have false-alarming sometimes if the separated rects will then be joind into the original rect,
+                    /** @todo this can have false-alarming sometimes if the separated rects will then be joind into the original rect,
                      * so far this should not be a problem for VReg clients, so keep it this way for now  */
                     fChanged = true;
@@ -961 +962 @@
         return VINF_SUCCESS;
 
-    /* @todo: fChanged will have false alarming here, fix if needed */
+    /** @todo fChanged will have false alarming here, fix if needed */
     VBoxVrListClear(pList);