Changeset 69399 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Oct 26, 2017 7:02:38 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

118726

Message:

Main/Medium: Fix an oversight introduced when using the ready made callback, which can't deal (and it makes no sense to do add it, if there's no progress object to call, why register any interface for getting progress callbacks?)

File:

• trunk/src/VBox/Main/src-server/MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MediumImpl.cpp

@@ -242 +242 @@
         /* Set up a per-operation progress interface, can be used freely (for
          * binary operations you can use it either on the source or target). */
-        mVDIfProgress.pfnProgress = aProgress->i_vdProgressCallback;
-        int vrc = VDInterfaceAdd(&mVDIfProgress.Core,
-                                 "Medium::Task::vdInterfaceProgress",
-                                 VDINTERFACETYPE_PROGRESS,
-                                 mProgress,
-                                 sizeof(mVDIfProgress),
-                                 &mVDOperationIfaces);
-        AssertRC(vrc);
-        if (RT_FAILURE(vrc))
-            mRC = E_FAIL;
+        if (mProgress)
+        {
+            mVDIfProgress.pfnProgress = aProgress->i_vdProgressCallback;
+            int vrc = VDInterfaceAdd(&mVDIfProgress.Core,
+                                     "Medium::Task::vdInterfaceProgress",
+                                     VDINTERFACETYPE_PROGRESS,
+                                     mProgress,
+                                     sizeof(mVDIfProgress),
+                                     &mVDOperationIfaces);
+            AssertRC(vrc);
+            if (RT_FAILURE(vrc))
+                mRC = E_FAIL;
+        }
     }