Changeset 69521 in vbox

Timestamp:

Oct 30, 2017 10:59:20 AM (7 years ago)

Author:

vboxsync

Message:

pemfile.cpp: Don't leak pSection if binary and _F_ONLY_PEM is used. (parfait/clang-analyzer)

File:

• trunk/src/VBox/Runtime/common/crypto/pemfile.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/crypto/pemfile.cpp

@@ -415 +415 @@
             RTCrPemFreeSections(*ppSectionHead);
         }
-        else if (!(fFlags & RTCRPEMREADFILE_F_ONLY_PEM))
-        {
-            /*
-             * No PEM section found.  Return the whole file as one binary section.
-             */
-            //pSection->pNext       = NULL;
-            //pSection->pMarker     = NULL;
-            pSection->pbData        = (uint8_t *)RTMemDup(pbContent, cbContent);
-            pSection->cbData        = cbContent;
-            //pSection->pszPreamble = NULL;
-            //pSection->cchPreamble = 0;
-            if (pSection->pbData)
+        else
+        {
+            if (!(fFlags & RTCRPEMREADFILE_F_ONLY_PEM))
             {
-                *ppSectionHead = pSection;
-                return VINF_SUCCESS;
+                /*
+                 * No PEM section found.  Return the whole file as one binary section.
+                 */
+                //pSection->pNext       = NULL;
+                //pSection->pMarker     = NULL;
+                pSection->pbData        = (uint8_t *)RTMemDup(pbContent, cbContent);
+                pSection->cbData        = cbContent;
+                //pSection->pszPreamble = NULL;
+                //pSection->cchPreamble = 0;
+                if (pSection->pbData)
+                {
+                    *ppSectionHead = pSection;
+                    return VINF_SUCCESS;
+                }
+
+                rc = VERR_NO_MEMORY;
             }
-
-            rc = VERR_NO_MEMORY;
+            else
+                rc = VWRN_NOT_FOUND;
             RTMemFree(pSection);
         }
-        else
-            rc = VWRN_NOT_FOUND;
     }
     else