Changeset 69522 in vbox for trunk

Timestamp:

Oct 30, 2017 11:04:53 AM (7 years ago)

Author:

vboxsync

Message:

pkzip: Fixed memory leak and missing error code in unlikely error path. (parfait/clang-analyzer)

File:

• trunk/src/VBox/Runtime/common/zip/pkzip.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/zip/pkzip.cpp

@@ -221 +221 @@
                         {
                             RTVFSIOSTREAM hVfsIosObj = RTVfsObjToIoStream(hVfsObj);
-                            if (hVfsIos)
+                            if (hVfsIos != NIL_RTVFSIOSTREAM)
                             {
                                 rc = RTVfsIoStrmRead(hVfsIosObj, pv, cb, true /*fBlocking*/, NULL);
@@ -229 +229 @@
                                     *pcbDst = cb;
                                 }
-                                else
-                                    RTMemFree(pv);
                             }
+                            else
+                                rc = VERR_INTERNAL_ERROR_4;
+                            if (RT_FAILURE(rc))
+                                RTMemFree(pv);
                         }
                     }